From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>
Subject: [Qemu-devel] [PULL 3/4] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined
Date: Tue, 20 May 2014 20:14:41 +0200 [thread overview]
Message-ID: <1400609682-22166-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1400609682-22166-1-git-send-email-pbonzini@redhat.com>
From: Jeff Cody <jcody@redhat.com>
Commit b03c380 introduced the function
iscsi_allocationmap_is_allocated(), however it is only used within a
code block that is conditionally compiled. This produces a warning
(error with -werror) of "defined but not used" for the the function, if
LIBISCSI_FEATURE_IOVECTOR is not defined.
This wraps iscsi_allocationmap_is_allocated() in the same conditional.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 65bf97d..1b4af77 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -381,6 +381,7 @@ retry:
}
+#if defined(LIBISCSI_FEATURE_IOVECTOR)
static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
int64_t sector_num, int nb_sectors)
{
@@ -393,9 +394,6 @@ static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
sector_num / iscsilun->cluster_sectors) == size);
}
-
-#if defined(LIBISCSI_FEATURE_IOVECTOR)
-
static int64_t coroutine_fn iscsi_co_get_block_status(BlockDriverState *bs,
int64_t sector_num,
int nb_sectors, int *pnum)
--
1.8.3.1
next prev parent reply other threads:[~2014-05-20 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 18:14 [Qemu-devel] [PULL 00/15] SCSI changes for 2014-05-20 Paolo Bonzini
2014-05-20 18:14 ` [Qemu-devel] [PULL 1/4] scsi: Document intentional fall through in scsi_req_length() Paolo Bonzini
2014-05-20 18:14 ` [Qemu-devel] [PULL 2/4] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path Paolo Bonzini
2014-05-20 18:14 ` Paolo Bonzini [this message]
2014-05-20 18:14 ` [Qemu-devel] [PULL 4/4] megasas: remove buildtime strings Paolo Bonzini
2014-05-22 15:13 ` [Qemu-devel] [PULL 00/15] SCSI changes for 2014-05-20 Peter Maydell
2014-05-22 15:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400609682-22166-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).