From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Olaf Hering <olaf@aepfle.de>
Subject: [Qemu-devel] [PULL 4/4] megasas: remove buildtime strings
Date: Tue, 20 May 2014 20:14:42 +0200 [thread overview]
Message-ID: <1400609682-22166-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1400609682-22166-1-git-send-email-pbonzini@redhat.com>
From: Olaf Hering <olaf@aepfle.de>
Using __DATE__ or __TIME__ in binary pkgs changes the checksum of
compiled binaries if they get rebuilt, even if there are no other
source changes. Replace the dynamic strings with some equally
informative static strings.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/megasas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index baee46f..0e109a2 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -728,8 +728,8 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION);
memcpy(info.image_component[0].name, "APP", 3);
memcpy(info.image_component[0].version, MEGASAS_VERSION "-QEMU", 9);
- memcpy(info.image_component[0].build_date, __DATE__, 11);
- memcpy(info.image_component[0].build_time, __TIME__, 8);
+ memcpy(info.image_component[0].build_date, "Apr 1 2014", 11);
+ memcpy(info.image_component[0].build_time, "12:34:56", 8);
info.image_component_count = 1;
if (pci_dev->has_rom) {
uint8_t biosver[32];
--
1.8.3.1
next prev parent reply other threads:[~2014-05-20 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 18:14 [Qemu-devel] [PULL 00/15] SCSI changes for 2014-05-20 Paolo Bonzini
2014-05-20 18:14 ` [Qemu-devel] [PULL 1/4] scsi: Document intentional fall through in scsi_req_length() Paolo Bonzini
2014-05-20 18:14 ` [Qemu-devel] [PULL 2/4] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path Paolo Bonzini
2014-05-20 18:14 ` [Qemu-devel] [PULL 3/4] block: iscsi build fix if LIBISCSI_FEATURE_IOVECTOR is not defined Paolo Bonzini
2014-05-20 18:14 ` Paolo Bonzini [this message]
2014-05-22 15:13 ` [Qemu-devel] [PULL 00/15] SCSI changes for 2014-05-20 Peter Maydell
2014-05-22 15:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400609682-22166-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).