qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] iscsi: Fix compile error
@ 2014-05-21  3:49 Alexey Kardashevskiy
  2014-05-21  3:53 ` Alexey Kardashevskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2014-05-21  3:49 UTC (permalink / raw)
  To: qemu-devel
  Cc: Alexey Kardashevskiy, qemu-trivial, Peter Lieven, Paolo Bonzini

This fixes compile error when LIBISCSI_FEATURE_IOVECTOR is not defined:

block/iscsi.c|384 col 13| error: 'iscsi_allocationmap_is_allocated' defined but not used [-Werror=unused-f    unction]

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 block/iscsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index d649424..5b3f459 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -380,6 +380,7 @@ retry:
     return 0;
 }
 
+#if defined(LIBISCSI_FEATURE_IOVECTOR)
 
 static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
                                              int64_t sector_num, int nb_sectors)
@@ -393,9 +394,6 @@ static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
                            sector_num / iscsilun->cluster_sectors) == size);
 }
 
-
-#if defined(LIBISCSI_FEATURE_IOVECTOR)
-
 static int64_t coroutine_fn iscsi_co_get_block_status(BlockDriverState *bs,
                                                   int64_t sector_num,
                                                   int nb_sectors, int *pnum)
-- 
1.9.rc0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] iscsi: Fix compile error
  2014-05-21  3:49 [Qemu-devel] [PATCH] iscsi: Fix compile error Alexey Kardashevskiy
@ 2014-05-21  3:53 ` Alexey Kardashevskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Kardashevskiy @ 2014-05-21  3:53 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Peter Lieven

On 05/21/2014 01:49 PM, Alexey Kardashevskiy wrote:
> This fixes compile error when LIBISCSI_FEATURE_IOVECTOR is not defined:
> 
> block/iscsi.c|384 col 13| error: 'iscsi_allocationmap_is_allocated' defined but not used [-Werror=unused-f    unction]

Oops, never mind. Fix is already on its way.


> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  block/iscsi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index d649424..5b3f459 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -380,6 +380,7 @@ retry:
>      return 0;
>  }
>  
> +#if defined(LIBISCSI_FEATURE_IOVECTOR)
>  
>  static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
>                                               int64_t sector_num, int nb_sectors)
> @@ -393,9 +394,6 @@ static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun,
>                             sector_num / iscsilun->cluster_sectors) == size);
>  }
>  
> -
> -#if defined(LIBISCSI_FEATURE_IOVECTOR)
> -
>  static int64_t coroutine_fn iscsi_co_get_block_status(BlockDriverState *bs,
>                                                    int64_t sector_num,
>                                                    int nb_sectors, int *pnum)
> 


-- 
Alexey

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-21  3:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21  3:49 [Qemu-devel] [PATCH] iscsi: Fix compile error Alexey Kardashevskiy
2014-05-21  3:53 ` Alexey Kardashevskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).