From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn1hE-0003AT-L3 for qemu-devel@nongnu.org; Wed, 21 May 2014 04:16:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn1h5-0004Ln-VJ for qemu-devel@nongnu.org; Wed, 21 May 2014 04:16:20 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:37369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn1h5-0004LJ-5c for qemu-devel@nongnu.org; Wed, 21 May 2014 04:16:11 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 May 2014 18:16:07 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id DAB672CE8040 for ; Wed, 21 May 2014 18:16:03 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4L7sSGY4850140 for ; Wed, 21 May 2014 17:54:28 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4L8G3oR032638 for ; Wed, 21 May 2014 18:16:03 +1000 From: Alexey Kardashevskiy Date: Wed, 21 May 2014 18:16:01 +1000 Message-Id: <1400660161-15925-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [RFC PATCH] trace: Replace error with warning if event is not defined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy At the moment QEMU exits if trace point is not defined which makes a developer life harder if he has to switch between branches with different traces implemented. This replaces error+exit wit WARNING if the tracepoint does not exist or not traceable. Signed-off-by: Alexey Kardashevskiy --- That would make my life easier indeed. Thanks :) --- trace/control.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/trace/control.c b/trace/control.c index 49f61e1..4aa02cf 100644 --- a/trace/control.c +++ b/trace/control.c @@ -112,15 +112,15 @@ void trace_backend_init_events(const char *fname) TraceEvent *ev = trace_event_name(line_ptr); if (ev == NULL) { fprintf(stderr, - "error: trace event '%s' does not exist\n", line_ptr); - exit(1); - } - if (!trace_event_get_state_static(ev)) { + "WARNING: trace event '%s' does not exist\n", + line_ptr); + } else if (!trace_event_get_state_static(ev)) { fprintf(stderr, - "error: trace event '%s' is not traceable\n", line_ptr); - exit(1); + "WARNING: trace event '%s' is not traceable\n", + line_ptr); + } else { + trace_event_set_state_dynamic(ev, enable); } - trace_event_set_state_dynamic(ev, enable); } } } -- 1.9.rc0