From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: qemu-devel@nongnu.org
Cc: romain@dolbeau.org, mst@redhat.com, agraf@suse.de,
stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v2 3/3] tests: e1000: test additional device IDs
Date: Wed, 21 May 2014 14:27:44 -0400 [thread overview]
Message-ID: <1400696864-22473-4-git-send-email-somlo@cmu.edu> (raw)
In-Reply-To: <1400696864-22473-1-git-send-email-somlo@cmu.edu>
Update e1000-test.c to check all currently supported devices.
Suggested-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
---
tests/e1000-test.c | 33 ++++++++++++++++++++++++++-------
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/tests/e1000-test.c b/tests/e1000-test.c
index a8ba2fc..81f164d 100644
--- a/tests/e1000-test.c
+++ b/tests/e1000-test.c
@@ -13,21 +13,40 @@
#include "qemu/osdep.h"
/* Tests only initialization so far. TODO: Replace with functional tests */
-static void nop(void)
+static void test_device(gconstpointer data)
{
+ const char *model = data;
+ QTestState *s;
+ char *args;
+
+ args = g_strdup_printf("-device %s", model);
+ s = qtest_start(args);
+
+ if (s) {
+ qtest_quit(s);
+ }
+ g_free(args);
}
+static const char *models[] = {
+ "e1000",
+ "e1000-82540em",
+ "e1000-82544gc",
+ "e1000-82545em",
+};
+
int main(int argc, char **argv)
{
- int ret;
+ int i;
g_test_init(&argc, &argv, NULL);
- qtest_add_func("/e1000/nop", nop);
- qtest_start("-device e1000");
- ret = g_test_run();
+ for (i = 0; i < ARRAY_SIZE(models); i++) {
+ char *path;
- qtest_end();
+ path = g_strdup_printf("/%s/e1000/%s", qtest_get_arch(), models[i]);
+ g_test_add_data_func(path, models[i], test_device);
+ }
- return ret;
+ return g_test_run();
}
--
1.9.0
prev parent reply other threads:[~2014-05-21 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 18:27 [Qemu-devel] [PATCH v2 0/3] e1000: allow model/device_id selection on command line Gabriel L. Somlo
2014-05-21 18:27 ` [Qemu-devel] [PATCH v2 1/3] e1000: avoid relying on device id (and soon, QOM) on data path Gabriel L. Somlo
2014-05-21 18:27 ` [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model Gabriel L. Somlo
2014-05-21 18:27 ` Gabriel L. Somlo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400696864-22473-4-git-send-email-somlo@cmu.edu \
--to=gsomlo@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=romain@dolbeau.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).