From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Andreas Faerber <afaerber@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Frederic Konrad <fred.konrad@greensocs.com>
Subject: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()
Date: Wed, 21 May 2014 22:22:46 +0200 [thread overview]
Message-ID: <1400703772-3324-2-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1400703772-3324-1-git-send-email-stefanha@redhat.com>
Sometimes an object needs to present a property which is actually on
another object, or it needs to provide an alias name for an existing
property.
Examples:
a.foo -> b.foo
a.old_name -> a.new_name
The new object_property_add_alias() API allows objects to alias a
property on another object. The source and target names can be
different.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/qom/object.h | 18 ++++++++++++++++++
qom/object.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 70 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index a641dcd..70cbd13 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1203,6 +1203,24 @@ void object_property_add_uint64_ptr(Object *obj, const char *name,
const uint64_t *v, Error **Errp);
/**
+ * object_property_add_alias:
+ * @obj: the object to add a property to
+ * @name: the name of the property
+ * @target_obj: the object to forward property access property to
+ * @target_name: the name of the property on the forwarded object
+ * @errp: if an error occurs, a pointer to an area to store the error
+ *
+ * Add an alias for a property on an object. This function will add a property
+ * of the same type as the forwarded property.
+ *
+ * The caller must ensure that <code>@target_obj</code> stays alive as long as
+ * this property exists.
+ */
+void object_property_add_alias(Object *obj, const char *name,
+ Object *target_obj, const char *target_name,
+ Error **errp);
+
+/**
* object_child_foreach:
* @obj: the object whose children will be navigated
* @fn: the iterator function to be called
diff --git a/qom/object.c b/qom/object.c
index e42b254..ff50f37 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1515,6 +1515,58 @@ void object_property_add_uint64_ptr(Object *obj, const char *name,
NULL, NULL, (void *)v, errp);
}
+typedef struct
+{
+ Object *target_obj;
+ const char *target_name;
+} AliasProperty;
+
+static void property_get_alias(Object *obj, struct Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ AliasProperty *prop = opaque;
+
+ object_property_get(prop->target_obj, v, prop->target_name, errp);
+}
+
+static void property_set_alias(Object *obj, struct Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ AliasProperty *prop = opaque;
+
+ object_property_set(prop->target_obj, v, prop->target_name, errp);
+}
+
+static void property_release_alias(Object *obj, const char *name, void *opaque)
+{
+ AliasProperty *prop = opaque;
+
+ g_free(prop);
+}
+
+void object_property_add_alias(Object *obj, const char *name,
+ Object *target_obj, const char *target_name,
+ Error **errp)
+{
+ AliasProperty *prop;
+ ObjectProperty *target_prop;
+
+ target_prop = object_property_find(target_obj, target_name, errp);
+ if (!target_prop) {
+ return;
+ }
+
+ prop = g_malloc(sizeof(*prop));
+ prop->target_obj = target_obj;
+ prop->target_name = target_name;
+
+ object_property_add(obj, name, target_prop->type,
+ property_get_alias,
+ property_set_alias,
+ property_release_alias,
+ prop, errp);
+}
+
static void object_instance_init(Object *obj)
{
object_property_add_str(obj, "type", qdev_get_type, NULL, NULL);
--
1.9.0
next prev parent reply other threads:[~2014-05-21 20:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 20:22 [Qemu-devel] [PATCH 0/7] virtio-blk: use alias properties in transport devices Stefan Hajnoczi
2014-05-21 20:22 ` Stefan Hajnoczi [this message]
2014-05-21 22:05 ` [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias() Paolo Bonzini
2014-05-22 10:23 ` Stefan Hajnoczi
2014-05-22 11:16 ` Paolo Bonzini
2014-05-22 14:02 ` Peter Crosthwaite
2014-05-22 14:05 ` Andreas Färber
2014-05-22 14:38 ` Stefan Hajnoczi
2014-05-23 6:23 ` Peter Crosthwaite
2014-05-22 14:05 ` Igor Mammedov
2014-05-22 14:39 ` Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 2/7] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 3/7] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-05-21 22:04 ` Paolo Bonzini
2014-05-22 10:17 ` Stefan Hajnoczi
2014-05-22 11:15 ` Paolo Bonzini
2014-05-22 10:18 ` Andreas Färber
2014-05-22 10:24 ` Stefan Hajnoczi
2014-05-22 10:32 ` Andreas Färber
2014-05-22 14:08 ` Peter Crosthwaite
2014-05-21 20:22 ` [Qemu-devel] [PATCH 5/7] virtio-blk: drop virtio_blk_set_conf() Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 6/7] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-05-21 20:22 ` [Qemu-devel] [PATCH 7/7] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400703772-3324-2-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=fred.konrad@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).