From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE
Date: Thu, 22 May 2014 07:47:03 +0200 [thread overview]
Message-ID: <1400737623.25874.14.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815F5F9A@SZXEMA503-MBS.china.huawei.com>
On Do, 2014-05-22 at 04:05 +0000, Gonglei (Arei) wrote:
> > -----Original Message-----
> > From: qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org
> > [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> > Behalf Of Gerd Hoffmann
> > Sent: Wednesday, May 21, 2014 6:54 PM
> > To: qemu-devel@nongnu.org
> > Cc: Gerd Hoffmann; Anthony Liguori
> > Subject: [Qemu-devel] [PATCH] vnc: refuse to set a password with
> > VNC_AUTH_NONE
> >
> > Current code silently changes the authentication settings
> > in case you try to set a password without password authentication
> > turned on. This is bad. Return an error instead.
> >
> > If we want allow changing auth settings at runtime this should
> > be done explicitly using a separate monitor command, not as
> > side effect of set_passwd.
> >
> Agreed. Do you have a plan to do this? Thanks.
No, unless someone comes up with a reasonable use case for this.
cheers,
Gerd
next prev parent reply other threads:[~2014-05-22 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 10:54 [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE Gerd Hoffmann
2014-05-22 4:05 ` Gonglei (Arei)
2014-05-22 5:47 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-11 15:54 Gerd Hoffmann
2013-12-11 16:06 ` Paolo Bonzini
2013-12-11 16:29 ` Gerd Hoffmann
2013-12-11 16:43 ` Paolo Bonzini
2013-12-12 12:44 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400737623.25874.14.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).