From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnLqW-0004wQ-M6
	for qemu-devel@nongnu.org; Thu, 22 May 2014 01:47:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnLqR-00040h-Ja
	for qemu-devel@nongnu.org; Thu, 22 May 2014 01:47:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnLqR-00040a-BT
	for qemu-devel@nongnu.org; Thu, 22 May 2014 01:47:11 -0400
Message-ID: <1400737623.25874.14.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 22 May 2014 07:47:03 +0200
In-Reply-To: <33183CC9F5247A488A2544077AF19020815F5F9A@SZXEMA503-MBS.china.huawei.com>
References: <1400669661-18353-1-git-send-email-kraxel@redhat.com>
	<33183CC9F5247A488A2544077AF19020815F5F9A@SZXEMA503-MBS.china.huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with
 VNC_AUTH_NONE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@amazon.com>

On Do, 2014-05-22 at 04:05 +0000, Gonglei (Arei) wrote:
> > -----Original Message-----
> > From: qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org
> > [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> > Behalf Of Gerd Hoffmann
> > Sent: Wednesday, May 21, 2014 6:54 PM
> > To: qemu-devel@nongnu.org
> > Cc: Gerd Hoffmann; Anthony Liguori
> > Subject: [Qemu-devel] [PATCH] vnc: refuse to set a password with
> > VNC_AUTH_NONE
> > 
> > Current code silently changes the authentication settings
> > in case you try to set a password without password authentication
> > turned on.  This is bad.  Return an error instead.
> > 
> > If we want allow changing auth settings at runtime this should
> > be done explicitly using a separate monitor command, not as
> > side effect of set_passwd.
> > 
> Agreed. Do you have a plan to do this? Thanks.

No, unless someone comes up with a reasonable use case for this.

cheers,
  Gerd