* [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.
@ 2014-05-22 11:33 Saravanakumar
2014-05-22 12:43 ` Andreas Färber
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Saravanakumar @ 2014-05-22 11:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Saravanakumar, mst
Move dereferencing of root only after verifying valid root pointer.
Signed-off-by: Saravanakumar <saravanakumar.punith@gmail.com>
---
hw/pci/pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 22fe5ee..8d6a8d4 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -605,13 +605,13 @@ PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, const char *devaddr)
int dom, bus;
unsigned slot;
- assert(!root->parent_dev);
-
if (!root) {
fprintf(stderr, "No primary PCI bus\n");
return NULL;
}
+ assert(!root->parent_dev);
+
if (!devaddr) {
*devfnp = -1;
return pci_find_bus_nr(root, 0);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.
2014-05-22 11:33 [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer Saravanakumar
@ 2014-05-22 12:43 ` Andreas Färber
2014-05-22 12:47 ` Paolo Bonzini
2014-05-23 20:09 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Färber @ 2014-05-22 12:43 UTC (permalink / raw)
To: Saravanakumar, qemu-devel; +Cc: qemu-trivial, mst
Am 22.05.2014 13:33, schrieb Saravanakumar:
> Move dereferencing of root only after verifying valid root pointer.
>
>
> Signed-off-by: Saravanakumar <saravanakumar.punith@gmail.com>
Looks sensible, but mst can hopefully tweak the overly long subject. No
need to write the same into subject and body. That said,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.
2014-05-22 11:33 [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer Saravanakumar
2014-05-22 12:43 ` Andreas Färber
@ 2014-05-22 12:47 ` Paolo Bonzini
2014-05-23 20:09 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-05-22 12:47 UTC (permalink / raw)
To: Saravanakumar, qemu-devel; +Cc: qemu-trivial, mst
Il 22/05/2014 13:33, Saravanakumar ha scritto:
> Move dereferencing of root only after verifying valid root pointer.
>
>
> Signed-off-by: Saravanakumar <saravanakumar.punith@gmail.com>
> ---
> hw/pci/pci.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 22fe5ee..8d6a8d4 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -605,13 +605,13 @@ PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, const char *devaddr)
> int dom, bus;
> unsigned slot;
>
> - assert(!root->parent_dev);
> -
> if (!root) {
> fprintf(stderr, "No primary PCI bus\n");
> return NULL;
> }
>
> + assert(!root->parent_dev);
> +
> if (!devaddr) {
> *devfnp = -1;
> return pci_find_bus_nr(root, 0);
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.
2014-05-22 11:33 [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer Saravanakumar
2014-05-22 12:43 ` Andreas Färber
2014-05-22 12:47 ` Paolo Bonzini
@ 2014-05-23 20:09 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-05-23 20:09 UTC (permalink / raw)
To: Saravanakumar, qemu-devel; +Cc: qemu-trivial, mst
22.05.2014 15:33, Saravanakumar wrote:
> Move dereferencing of root only after verifying valid root pointer.
Applied to -trivial, after removing duplicate commit comment.
Thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-23 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-22 11:33 [Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer Saravanakumar
2014-05-22 12:43 ` Andreas Färber
2014-05-22 12:47 ` Paolo Bonzini
2014-05-23 20:09 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).