From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Paul Durrant <paul.durrant@citrix.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device
Date: Thu, 22 May 2014 14:45:52 +0200 [thread overview]
Message-ID: <1400762752.25874.60.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1405221301100.14596@kaball.uk.xensource.com>
Hi,
> Given that libxl always passes -nodefaults to QEMU, this patch is going
> to effectively disable xen_platform_pci for all Xen users. It is not a
> good idea. With the patch applied a Xen user would have no way to enable
> xen_platform_pci except for passing some magic command line runes via
> device_model_args_hvm.
Indeed.
> > @@ -4101,6 +4103,7 @@ int main(int argc, char **argv, char **envp)
> > default_monitor = 0;
> > default_net = 0;
> > default_vga = 0;
> > + default_xenplatform = 0;
> > }
With that chunk removed -nodefaults will have no effect for the xen
platform device, but explicitly moving it somewhere else via -device
xen-platform,addr=$slot should still work.
cheers,
Gerd
next prev parent reply other threads:[~2014-05-22 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 7:20 [Qemu-devel] [PATCH] xen: make xen-platform a default device Gerd Hoffmann
2014-05-22 7:21 ` Michael S. Tsirkin
2014-05-22 10:57 ` Chen, Tiejun
2014-05-22 10:59 ` Michael S. Tsirkin
2014-05-22 12:11 ` Stefano Stabellini
2014-05-22 12:35 ` Michael S. Tsirkin
2014-05-22 12:53 ` Gerd Hoffmann
2014-05-22 14:00 ` Michael S. Tsirkin
2014-05-22 12:45 ` Gerd Hoffmann [this message]
2014-05-22 13:49 ` Stefano Stabellini
2014-05-22 12:50 ` Paolo Bonzini
2014-05-22 13:22 ` Gerd Hoffmann
2014-05-22 13:56 ` Stefano Stabellini
2014-05-23 10:08 ` Paul Durrant
2014-05-23 10:11 ` Stefano Stabellini
2014-05-23 10:18 ` Paul Durrant
2014-05-23 11:36 ` Stefano Stabellini
2014-05-23 11:51 ` Paul Durrant
2014-05-22 13:55 ` Stefano Stabellini
2014-05-22 14:03 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-05-23 13:03 Fabio Fantoni
2014-05-23 14:30 ` Stefano Stabellini
2014-05-23 15:02 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400762752.25874.60.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=mst@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).