From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45928)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnSNw-0008Pg-95
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:46:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnSNm-0003cF-SP
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:46:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WnSNm-0003br-KF
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:46:02 -0400
Message-ID: <1400762752.25874.60.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 22 May 2014 14:45:52 +0200
In-Reply-To: <alpine.DEB.2.02.1405221301100.14596@kaball.uk.xensource.com>
References: <1400743250-2315-1-git-send-email-kraxel@redhat.com>
	<alpine.DEB.2.02.1405221301100.14596@kaball.uk.xensource.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Paul Durrant <paul.durrant@citrix.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, mst@redhat.com

  Hi,

> Given that libxl always passes -nodefaults to QEMU, this patch is going
> to effectively disable xen_platform_pci for all Xen users. It is not a
> good idea. With the patch applied a Xen user would have no way to enable
> xen_platform_pci except for passing some magic command line runes via
> device_model_args_hvm.

Indeed.

> > @@ -4101,6 +4103,7 @@ int main(int argc, char **argv, char **envp)
> >          default_monitor = 0;
> >          default_net = 0;
> >          default_vga = 0;
> > +        default_xenplatform = 0;
> >      }

With that chunk removed -nodefaults will have no effect for the xen
platform device, but explicitly moving it somewhere else via -device
xen-platform,addr=$slot should still work.

cheers,
  Gerd