From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnUR7-0000Dn-Tc for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnUQx-0003Kk-7c for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnUQw-0003KB-W5 for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:27 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MEvPPJ019987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 22 May 2014 10:57:25 -0400 From: Markus Armbruster Date: Thu, 22 May 2014 16:57:16 +0200 Message-Id: <1400770642-18196-2-git-send-email-armbru@redhat.com> In-Reply-To: <1400770642-18196-1-git-send-email-armbru@redhat.com> References: <1400770642-18196-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/7] libcacard/vscclient: Bury some dead code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alevy@redhat.com Spotted by Coverity. Signed-off-by: Markus Armbruster --- libcacard/vscclient.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 3477ab3..29f4958 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -502,8 +502,7 @@ do_command(GIOChannel *source, if (reader != NULL) { error = vcard_emul_force_card_insert(reader); printf("insert %s, returned %d\n", - reader ? vreader_get_name(reader) - : "invalid reader", error); + vreader_get_name(reader), error); } else { printf("no reader by id %u found\n", reader_id); } @@ -515,8 +514,7 @@ do_command(GIOChannel *source, if (reader != NULL) { error = vcard_emul_force_card_remove(reader); printf("remove %s, returned %d\n", - reader ? vreader_get_name(reader) - : "invalid reader", error); + vreader_get_name(reader), error); } else { printf("no reader by id %u found\n", reader_id); } -- 1.9.0