qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: alevy@redhat.com
Subject: [Qemu-devel] [PATCH 5/7] libcacard: Convert two leftover realloc() to GLib
Date: Thu, 22 May 2014 16:57:20 +0200	[thread overview]
Message-ID: <1400770642-18196-6-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1400770642-18196-1-git-send-email-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 libcacard/cac.c            | 13 ++-----------
 libcacard/vcard_emul_nss.c |  6 +-----
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/libcacard/cac.c b/libcacard/cac.c
index 74ef3e3..05ce8a2 100644
--- a/libcacard/cac.c
+++ b/libcacard/cac.c
@@ -169,17 +169,8 @@ cac_applet_pki_process_apdu(VCard *card, VCardAPDU *apdu,
         }
         size = apdu->a_Lc;
 
-        sign_buffer = realloc(pki_applet->sign_buffer,
-                      pki_applet->sign_buffer_len+size);
-        if (sign_buffer == NULL) {
-            g_free(pki_applet->sign_buffer);
-            pki_applet->sign_buffer = NULL;
-            pki_applet->sign_buffer_len = 0;
-            *response = vcard_make_response(
-                            VCARD7816_STATUS_EXC_ERROR_MEMORY_FAILURE);
-            ret = VCARD_DONE;
-            break;
-        }
+        sign_buffer = g_realloc(pki_applet->sign_buffer,
+                                pki_applet->sign_buffer_len + size);
         memcpy(sign_buffer+pki_applet->sign_buffer_len, apdu->a_body, size);
         size += pki_applet->sign_buffer_len;
         switch (apdu->a_p1) {
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index 692534c..f98541f 100644
--- a/libcacard/vcard_emul_nss.c
+++ b/libcacard/vcard_emul_nss.c
@@ -1178,11 +1178,7 @@ vcard_emul_options(const char *args)
 
             if (opts->vreader_count >= reader_count) {
                 reader_count += READER_STEP;
-                vreaderOpt = realloc(opts->vreader,
-                                reader_count * sizeof(*vreaderOpt));
-                if (vreaderOpt == NULL) {
-                    return opts; /* we're done */
-                }
+                vreaderOpt = g_new(VirtualReaderOptions, reader_count);
             }
             opts->vreader = vreaderOpt;
             vreaderOpt = &vreaderOpt[opts->vreader_count];
-- 
1.9.0

  parent reply	other threads:[~2014-05-22 14:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 14:57 [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 1/7] libcacard/vscclient: Bury some dead code Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 2/7] libcacard: Plug memory leaks around vreader_get_reader_list() Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 3/7] libcacard/vreader: Drop broken recovery from failed assertion Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 4/7] libcacard/vreader: Tighten assertion to clarify intent Markus Armbruster
2014-05-22 14:57 ` Markus Armbruster [this message]
2014-05-23  9:26   ` [Qemu-devel] [PATCH 5/7] libcacard: Convert two leftover realloc() to GLib Michael Tokarev
2014-05-23  9:44     ` Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null Markus Armbruster
2014-05-22 14:57 ` [Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional Markus Armbruster
2014-05-22 17:01 ` [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400770642-18196-6-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).