From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnUR6-0000Dj-6k for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnUR0-0003Ld-2M for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnUQz-0003LN-QQ for qemu-devel@nongnu.org; Thu, 22 May 2014 10:57:30 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MEvRN5020392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 May 2014 10:57:28 -0400 From: Markus Armbruster Date: Thu, 22 May 2014 16:57:22 +0200 Message-Id: <1400770642-18196-8-git-send-email-armbru@redhat.com> In-Reply-To: <1400770642-18196-1-git-send-email-armbru@redhat.com> References: <1400770642-18196-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alevy@redhat.com Bailing out when PK11_FindGenericObjects() returns null ensures the loop that follows it executes at least once. The "loop did not execute" test right after it is useless. Drop it. Spotted by Coverity. Signed-off-by: Markus Armbruster --- libcacard/vcard_emul_nss.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c index 83b89e4..2ebe13f 100644 --- a/libcacard/vcard_emul_nss.c +++ b/libcacard/vcard_emul_nss.c @@ -618,11 +618,6 @@ vcard_emul_mirror_card(VReader *vreader) cert_count++; } - if (cert_count == 0) { - PK11_DestroyGenericObjects(firstObj); - return NULL; - } - /* allocate the arrays */ vcard_emul_alloc_arrays(&certs, &cert_len, &keys, cert_count); -- 1.9.0