qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Christophe Fergeau" <cfergeau@redhat.com>,
	"Alon Levy" <alevy@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.so
Date: Fri, 23 May 2014 11:02:26 +0800	[thread overview]
Message-ID: <1400814150-31666-1-git-send-email-famz@redhat.com> (raw)

We get:

    $ qemu-img
    Failed to open module: /home/fam/build/master/block-iscsi.so: undefined symbol: bitmap_set
    qemu-img: Not enough arguments
    Try 'qemu-img --help' for more information

Because since commit b03c38 (block/iscsi: speed up read for unallocated
sectors), block/iscsi.c calls utils/bitmap.c:bitmap_* functions, which is not
linked to qemu-img nor shared objects.

This series links module objects to libqemuutil.a. That requires -fPIC on the
static library objects. The first patch unifies the dependency path of
util-obj-y to libqemuutil.a by removing individual object list from
libcacard-obj-y, so we can apply -fPIC from libqemuutils.a's object specific
variables.

Also added a travis build task for --enable-modules.

Fam

Fam Zheng (4):
  Makefile: Link vscclient with libqemuutil.a and libqemustub.a
  Makefile: Compile libqemustub.a and libqemuutil.a with -fPIC
  rules.mak: Link DSO with libqemuutil.a
  .travis.yml: Add a new build target with --enable-modules

 .travis.yml        | 3 +++
 Makefile           | 1 +
 libcacard/Makefile | 9 ++-------
 rules.mak          | 2 +-
 4 files changed, 7 insertions(+), 8 deletions(-)

-- 
1.9.2

             reply	other threads:[~2014-05-23  3:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  3:02 Fam Zheng [this message]
2014-05-23  3:02 ` [Qemu-devel] [PATCH 1/4] Makefile: Link vscclient with libqemuutil.a and libqemustub.a Fam Zheng
2014-05-23  8:22   ` Paolo Bonzini
2014-05-23  8:26     ` Michael Tokarev
2014-05-23  9:25       ` Paolo Bonzini
2014-05-23  9:36         ` Michael Tokarev
2014-05-23 11:33           ` Paolo Bonzini
2014-05-23  3:02 ` [Qemu-devel] [PATCH 2/4] Makefile: Compile libqemustub.a and libqemuutil.a with -fPIC Fam Zheng
2014-05-23  3:02 ` [Qemu-devel] [PATCH 3/4] rules.mak: Link DSO with libqemuutil.a Fam Zheng
2014-05-23  3:02 ` [Qemu-devel] [PATCH 4/4] .travis.yml: Add a new build target with --enable-modules Fam Zheng
2014-05-23  9:59 ` [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.so Michael Tokarev
2014-05-23 11:35   ` Paolo Bonzini
2014-05-23 11:36 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400814150-31666-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=alevy@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cfergeau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).