From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wnh51-00074X-3N for qemu-devel@nongnu.org; Fri, 23 May 2014 00:27:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wnh4z-0004nS-Dk for qemu-devel@nongnu.org; Fri, 23 May 2014 00:27:39 -0400 From: Jules Wang Date: Fri, 23 May 2014 11:44:05 +0800 Message-Id: <1400816645-16005-1-git-send-email-junqing.wang@cs2c.com.cn> Subject: [Qemu-devel] [PATCH] dma-helpers: avoid calling dma_bdrv_unmap() twice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Jules Wang Calling dma_bdrv_unmap() twice is not necessary and may cause potential problems if some code changes. Signed-off-by: Jules Wang --- dma-helpers.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 5f421e9..53cbe92 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -143,12 +143,12 @@ static void dma_bdrv_cb(void *opaque, int ret) dbs->acb = NULL; dbs->sector_num += dbs->iov.size / 512; - dma_bdrv_unmap(dbs); if (dbs->sg_cur_index == dbs->sg->nsg || ret < 0) { dma_complete(dbs, ret); return; } + dma_bdrv_unmap(dbs); while (dbs->sg_cur_index < dbs->sg->nsg) { cur_addr = dbs->sg->sg[dbs->sg_cur_index].base + dbs->sg_cur_byte; -- 1.7.1