From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wnnam-000383-M7 for qemu-devel@nongnu.org; Fri, 23 May 2014 07:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wnnaf-0000cq-Uz for qemu-devel@nongnu.org; Fri, 23 May 2014 07:24:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wnnaf-0000cR-MM for qemu-devel@nongnu.org; Fri, 23 May 2014 07:24:45 -0400 From: Markus Armbruster Date: Fri, 23 May 2014 13:24:39 +0200 Message-Id: <1400844279-1685-8-git-send-email-armbru@redhat.com> In-Reply-To: <1400844279-1685-1-git-send-email-armbru@redhat.com> References: <1400844279-1685-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mjt@tls.msk.ru, alevy@redhat.com Bailing out when PK11_FindGenericObjects() returns null ensures the loop that follows it executes at least once. The "loop did not execute" test right after it is useless. Drop it. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy --- libcacard/vcard_emul_nss.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c index 4f55e44..8f8e9e0 100644 --- a/libcacard/vcard_emul_nss.c +++ b/libcacard/vcard_emul_nss.c @@ -618,11 +618,6 @@ vcard_emul_mirror_card(VReader *vreader) cert_count++; } - if (cert_count == 0) { - PK11_DestroyGenericObjects(firstObj); - return NULL; - } - /* allocate the arrays */ vcard_emul_alloc_arrays(&certs, &cert_len, &keys, cert_count); -- 1.9.0