* [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits
@ 2014-05-24 0:16 Andrew Oates
2014-05-24 7:02 ` Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Oates @ 2014-05-24 0:16 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Andrew Oates
Without the mask, control bits are passed on in the keycode, generating
incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
Signed-off-by: Andrew Oates <andrew@aoates.org>
---
ui/curses.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/curses.c b/ui/curses.c
index b044790..de85f76 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -288,8 +288,8 @@ static void curses_refresh(DisplayChangeListener *dcl)
qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, true);
}
- qemu_input_event_send_key_number(NULL, keycode, true);
- qemu_input_event_send_key_number(NULL, keycode, false);
+ qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, true);
+ qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, false);
if (keycode & ALTGR) {
qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, false);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits
2014-05-24 0:16 [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits Andrew Oates
@ 2014-05-24 7:02 ` Michael Tokarev
2014-05-26 7:51 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2014-05-24 7:02 UTC (permalink / raw)
To: Andrew Oates, qemu-devel; +Cc: qemu-trivial, Gerd Hoffmann
24.05.2014 04:16, Andrew Oates wrote:
> Without the mask, control bits are passed on in the keycode, generating
> incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
While the patch itself appears to be trivial, it may have
non-trivial effect. Cc'ing Gerd for comments.
Thank you!
/mjt
> Signed-off-by: Andrew Oates <andrew@aoates.org>
> ---
> ui/curses.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/curses.c b/ui/curses.c
> index b044790..de85f76 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -288,8 +288,8 @@ static void curses_refresh(DisplayChangeListener *dcl)
> qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, true);
> }
>
> - qemu_input_event_send_key_number(NULL, keycode, true);
> - qemu_input_event_send_key_number(NULL, keycode, false);
> + qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, true);
> + qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, false);
>
> if (keycode & ALTGR) {
> qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, false);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits
2014-05-24 7:02 ` Michael Tokarev
@ 2014-05-26 7:51 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2014-05-26 7:51 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Andrew Oates, qemu-devel
On Sa, 2014-05-24 at 11:02 +0400, Michael Tokarev wrote:
> 24.05.2014 04:16, Andrew Oates wrote:
> > Without the mask, control bits are passed on in the keycode, generating
> > incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
>
> While the patch itself appears to be trivial, it may have
> non-trivial effect. Cc'ing Gerd for comments.
Patch is correct, picked it up.
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-26 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-24 0:16 [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits Andrew Oates
2014-05-24 7:02 ` Michael Tokarev
2014-05-26 7:51 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).