From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Andrew Oates <andrew@aoates.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits
Date: Mon, 26 May 2014 09:51:02 +0200 [thread overview]
Message-ID: <1401090662.13567.0.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <538043ED.20200@msgid.tls.msk.ru>
On Sa, 2014-05-24 at 11:02 +0400, Michael Tokarev wrote:
> 24.05.2014 04:16, Andrew Oates wrote:
> > Without the mask, control bits are passed on in the keycode, generating
> > incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
>
> While the patch itself appears to be trivial, it may have
> non-trivial effect. Cc'ing Gerd for comments.
Patch is correct, picked it up.
cheers,
Gerd
prev parent reply other threads:[~2014-05-26 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 0:16 [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits Andrew Oates
2014-05-24 7:02 ` Michael Tokarev
2014-05-26 7:51 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401090662.13567.0.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=andrew@aoates.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).