From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Wopgs-0004NL-Kc
	for qemu-devel@nongnu.org; Mon, 26 May 2014 03:51:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Wopgf-0007mZ-6a
	for qemu-devel@nongnu.org; Mon, 26 May 2014 03:51:26 -0400
Message-ID: <1401090662.13567.0.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 26 May 2014 09:51:02 +0200
In-Reply-To: <538043ED.20200@msgid.tls.msk.ru>
References: <1400890569-30822-1-git-send-email-andrew@aoates.org>
	<538043ED.20200@msgid.tls.msk.ru>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove
 modifier bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Andrew Oates <andrew@aoates.org>, qemu-devel@nongnu.org

On Sa, 2014-05-24 at 11:02 +0400, Michael Tokarev wrote:
> 24.05.2014 04:16, Andrew Oates wrote:
> > Without the mask, control bits are passed on in the keycode, generating
> > incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
> 
> While the patch itself appears to be trivial, it may have
> non-trivial effect.  Cc'ing Gerd for comments.

Patch is correct, picked it up.

cheers,
  Gerd