qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Andrew Oates <andrew@aoates.org>,
	qemu-stable@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 01/10] input (curses): mask keycodes to remove modifier bits
Date: Mon, 26 May 2014 09:51:17 +0200	[thread overview]
Message-ID: <1401090686-1095-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1401090686-1095-1-git-send-email-kraxel@redhat.com>

From: Andrew Oates <andrew@aoates.org>

Without the mask, control bits are passed on in the keycode, generating
incorrect PS/2 sequences when SHIFT, ALT, etc are held down.

Cc: qemu-stable@nongnu.org
Signed-off-by: Andrew Oates <andrew@aoates.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/curses.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/curses.c b/ui/curses.c
index b044790..de85f76 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -288,8 +288,8 @@ static void curses_refresh(DisplayChangeListener *dcl)
                 qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, true);
             }
 
-            qemu_input_event_send_key_number(NULL, keycode, true);
-            qemu_input_event_send_key_number(NULL, keycode, false);
+            qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, true);
+            qemu_input_event_send_key_number(NULL, keycode & KEY_MASK, false);
 
             if (keycode & ALTGR) {
                 qemu_input_event_send_key_number(NULL, GREY | ALT_CODE, false);
-- 
1.8.3.1

  reply	other threads:[~2014-05-26  7:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26  7:51 [Qemu-devel] [PULL 00/10] input: add event routing and multiseat support Gerd Hoffmann
2014-05-26  7:51 ` Gerd Hoffmann [this message]
2014-05-26  7:51 ` [Qemu-devel] [PULL 02/10] input: add qemu_input_key_number_to_qcode Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 03/10] input: add name to input_event_key_number Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 04/10] input: keymap: add meta keys Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 05/10] input: switch hid keyboard to new input layer api Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 06/10] input: switch hid mouse and tablet to the " Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 07/10] input: bind devices and input routing Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 08/10] sdl: pass key event source to input layer Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 09/10] usb: add input routing support for tablet and keyboard Gerd Hoffmann
2014-05-26  7:51 ` [Qemu-devel] [PULL 10/10] docs: add multiseat.txt Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401090686-1095-2-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=andrew@aoates.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).