From: Gerd Hoffmann <kraxel@redhat.com>
To: Dave Mielke <dave@mielke.cc>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays
Date: Mon, 02 Jun 2014 13:28:18 +0200 [thread overview]
Message-ID: <1401708498.22391.41.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140602104040.GE10889@beta.private.mielke.cc>
On Mo, 2014-06-02 at 06:40 -0400, Dave Mielke wrote:
> [quoted lines by Gerd Hoffmann on 2014/06/02 at 11:29 +0200]
>
> Hi:
>
> When using my patch, I'm specifying -k delay=20 (so 20ms).
>
> >Highest repeat rate ps/2 allows is 30Hz. Which is 33 ms delay per key
> >event. We have two delays in there (one after pressing all keys, one
> >after releasing all keys). So something between 10 and 15 ms should be
> >short enough to make sure the queue doesn't grow. Lets try that,
> >incremental patch attached.
>
> Key repeat now stops when it should, and letting go of backspace as soon as all
> the characters are gone no longer leaves me with a temporarily dead keyboard.
> There are still problems, though. When I hold the shift key and type a letter,
> I get a doubled lowercase letter rather than a single uppercase letter. Also, I
> still get doubled lowercase letters when holding the control key.
Ok, so looks like the guest really needs a delay after every single key
event, grouping all down and all up events doesn't work. New version of
the patch series goes out in a moment. That should fix both curses ui
and monitor sendkey command.
cheers,
Gerd
prev parent reply other threads:[~2014-06-02 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401280016-20851-1-git-send-email-kraxel@redhat.com>
[not found] ` <20140531160354.GI13640@beta.private.mielke.cc>
2014-06-02 7:07 ` [Qemu-devel] [PATCH 0/3] input: add support for kbd delays Gerd Hoffmann
2014-06-02 8:50 ` Dave Mielke
2014-06-02 9:31 ` Gerd Hoffmann
2014-06-02 10:43 ` Dave Mielke
2014-06-02 9:00 ` Dave Mielke
2014-06-02 9:29 ` Gerd Hoffmann
2014-06-02 10:40 ` Dave Mielke
2014-06-02 11:28 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401708498.22391.41.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dave@mielke.cc \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).