From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrQPo-0005BK-EB for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:28:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrQPi-0002lI-BJ for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:28:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrQPi-0002l5-37 for qemu-devel@nongnu.org; Mon, 02 Jun 2014 07:28:26 -0400 Message-ID: <1401708498.22391.41.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 02 Jun 2014 13:28:18 +0200 In-Reply-To: <20140602104040.GE10889@beta.private.mielke.cc> References: <1401280016-20851-1-git-send-email-kraxel@redhat.com> <20140531160354.GI13640@beta.private.mielke.cc> <1401692854.22391.3.camel@nilsson.home.kraxel.org> <20140602090027.GD10889@beta.private.mielke.cc> <1401701382.22391.36.camel@nilsson.home.kraxel.org> <20140602104040.GE10889@beta.private.mielke.cc> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Mielke Cc: qemu-devel@nongnu.org On Mo, 2014-06-02 at 06:40 -0400, Dave Mielke wrote: > [quoted lines by Gerd Hoffmann on 2014/06/02 at 11:29 +0200] > > Hi: > > When using my patch, I'm specifying -k delay=20 (so 20ms). > > >Highest repeat rate ps/2 allows is 30Hz. Which is 33 ms delay per key > >event. We have two delays in there (one after pressing all keys, one > >after releasing all keys). So something between 10 and 15 ms should be > >short enough to make sure the queue doesn't grow. Lets try that, > >incremental patch attached. > > Key repeat now stops when it should, and letting go of backspace as soon as all > the characters are gone no longer leaves me with a temporarily dead keyboard. > There are still problems, though. When I hold the shift key and type a letter, > I get a doubled lowercase letter rather than a single uppercase letter. Also, I > still get doubled lowercase letters when holding the control key. Ok, so looks like the guest really needs a delay after every single key event, grouping all down and all up events doesn't work. New version of the patch series goes out in a moment. That should fix both curses ui and monitor sendkey command. cheers, Gerd