From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrSjS-00026Y-SS for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:57:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrSjN-0003M0-Qb for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:56:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrSjN-0003Lv-JW for qemu-devel@nongnu.org; Mon, 02 Jun 2014 09:56:53 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s52DuqCn009778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 2 Jun 2014 09:56:53 -0400 From: Kevin Wolf Date: Mon, 2 Jun 2014 15:56:33 +0200 Message-Id: <1401717408-4607-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1401717408-4607-1-git-send-email-kwolf@redhat.com> References: <1401717408-4607-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 02/17] block/vvfat: Plug memory leak in enable_write_target() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Markus Armbruster I figure the leak originated in bdrv_create2(), and was duplicated into callers when commit 91a073a dropped that function. Looks like the other places have since been fixed. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf --- block/vvfat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vvfat.c b/block/vvfat.c index 8f5114b..811b39c 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2929,6 +2929,7 @@ static int enable_write_target(BDRVVVFATState *s, Error **errp) set_option_parameter(options, BLOCK_OPT_BACKING_FILE, "fat:"); ret = bdrv_create(bdrv_qcow, s->qcow_filename, options, errp); + free_option_parameters(options); if (ret < 0) { goto err; } -- 1.8.3.1