qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PULL 06/17] qemu-io: Plug memory leak in open command
Date: Mon,  2 Jun 2014 15:56:37 +0200	[thread overview]
Message-ID: <1401717408-4607-7-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1401717408-4607-1-git-send-email-kwolf@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Introduced in commit b543c5c.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qemu-io.c b/qemu-io.c
index ef3fef6..f63e771 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -54,6 +54,7 @@ static int openfile(char *name, int flags, int growable, QDict *opts)
 
     if (qemuio_bs) {
         fprintf(stderr, "file open already, try 'help close'\n");
+        QDECREF(opts);
         return 1;
     }
 
@@ -175,6 +176,7 @@ static int open_f(BlockDriverState *bs, int argc, char **argv)
     } else if (optind == argc) {
         return openfile(NULL, flags, growable, opts);
     } else {
+        QDECREF(opts);
         return qemuio_command_usage(&open_cmd);
     }
 }
-- 
1.8.3.1

  parent reply	other threads:[~2014-06-02 13:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 13:56 [Qemu-devel] [PULL 00/17] Block patches Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 01/17] qemu-img: Plug memory leak on block option help error path Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 02/17] block/vvfat: Plug memory leak in enable_write_target() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 03/17] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 04/17] block: Plug memory leak on brv_open_image() error path Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 05/17] qemu-io: Support multiple -o in open command Kevin Wolf
2014-06-02 13:56 ` Kevin Wolf [this message]
2014-06-02 13:56 ` [Qemu-devel] [PULL 07/17] qemu-io: Don't print NULL when open without non-option arg fails Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 08/17] blockdev: Plug memory leak in blockdev_init() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 09/17] blockdev: Plug memory leak in drive_init() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 10/17] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 11/17] block/vvfat: Plug memory leak in check_directory_consistency() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 12/17] block/vvfat: Plug memory leak in read_directory() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 13/17] block/sheepdog: Plug memory leak in sd_snapshot_create() Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 14/17] qemu-img: Plug memory leak in convert command Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 15/17] block/raw-posix.c: Avoid nonstandard LONG_LONG_MAX Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 16/17] vmdk: Fix local_err in vmdk_create Kevin Wolf
2014-06-02 13:56 ` [Qemu-devel] [PULL 17/17] qemu-img: Report error even with --oformat=json Kevin Wolf
2014-06-02 14:46 ` [Qemu-devel] [PULL 00/17] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401717408-4607-7-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).