From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTpx-0007eB-2Q for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrTpq-0003mN-Br for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:45 -0400 Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:38123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTpq-0003ln-5Q for qemu-devel@nongnu.org; Mon, 02 Jun 2014 11:07:38 -0400 Received: by mail-pb0-f47.google.com with SMTP id rp16so4311800pbb.20 for ; Mon, 02 Jun 2014 08:07:37 -0700 (PDT) From: Hitoshi Mitake Date: Tue, 3 Jun 2014 00:06:50 +0900 Message-Id: <1401721610-12920-3-git-send-email-mitake.hitoshi@gmail.com> In-Reply-To: <1401721610-12920-1-git-send-email-mitake.hitoshi@gmail.com> References: <1401721610-12920-1-git-send-email-mitake.hitoshi@gmail.com> Subject: [Qemu-devel] [PATCH 2/2] sheepdog: reload only header in a case of live snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , sheepdog@lists.wpkg.org, mitake.hitoshi@gmail.com, Hitoshi Mitake , Stefan Hajnoczi , Liu Yuan , MORITA Kazutaka sheepdog dirver doesn't need to read data_vdi_id[] when a live snapshot is created. Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Liu Yuan Cc: MORITA Kazutaka Signed-off-by: Hitoshi Mitake --- block/sheepdog.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 8266382..06c4180 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -200,6 +200,8 @@ typedef struct SheepdogInode { uint32_t data_vdi_id[MAX_DATA_OBJS]; } SheepdogInode; +#define SD_INODE_HEADER_SIZE offsetof(SheepdogInode, data_vdi_id) + /* * 64 bit FNV-1a non-zero initial basis */ @@ -1275,7 +1277,7 @@ static int reload_inode(BDRVSheepdogState *s, uint32_t snapid, const char *tag) return -EIO; } - inode = g_malloc(sizeof(s->inode)); + inode = g_malloc(SD_INODE_HEADER_SIZE); ret = find_vdi_name(s, s->name, snapid, tag, &vid, false); if (ret) { @@ -1283,13 +1285,14 @@ static int reload_inode(BDRVSheepdogState *s, uint32_t snapid, const char *tag) } ret = read_object(fd, (char *)inode, vid_to_vdi_oid(vid), - s->inode.nr_copies, sizeof(*inode), 0, s->cache_flags); + s->inode.nr_copies, SD_INODE_HEADER_SIZE, 0, + s->cache_flags); if (ret < 0) { goto out; } if (inode->vdi_id != s->inode.vdi_id) { - memcpy(&s->inode, inode, sizeof(s->inode)); + memcpy(&s->inode, inode, SD_INODE_HEADER_SIZE); } out: -- 1.9.1