qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read
Date: Tue,  3 Jun 2014 20:52:58 +0800	[thread overview]
Message-ID: <1401799978-9558-6-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1401799978-9558-1-git-send-email-famz@redhat.com>

Since it's set but not used.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/block/dataplane/virtio-blk.c | 1 -
 include/hw/virtio/virtio-blk.h  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index b88eee9..c75141b 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -129,7 +129,6 @@ static void do_rdwr_cmd(VirtIOBlockDataPlane *s, bool read,
     req->s = s;
     req->elem = elem;
     req->inhdr = inhdr;
-    req->read = read;
     qemu_iovec_init_external(&req->qiov, iov, iov_cnt);
 
     qiov = &req->qiov;
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index e406efa..74f0f32 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -146,7 +146,6 @@ typedef struct VirtIOBlockReq {
 #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
     struct VirtIOBlockDataPlane *s;
     QEMUIOVector *inhdr;            /* iovecs for virtio_blk_inhdr */
-    bool read;                      /* read or write? */
 #endif
 } VirtIOBlockReq;
 
-- 
1.9.2

  parent reply	other threads:[~2014-06-03 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 12:52 [Qemu-devel] [PATCH 0/5] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 1/5] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 2/5] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 3/5] virtio-blk: Merge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-03 12:52 ` [Qemu-devel] [PATCH 4/5] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-03 13:28   ` Paolo Bonzini
2014-06-03 12:52 ` Fam Zheng [this message]
2014-06-03 13:37   ` [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read Paolo Bonzini
2014-06-04  7:10     ` Fam Zheng
2014-06-04  7:53     ` Fam Zheng
2014-06-04  8:42       ` Paolo Bonzini
2014-06-04 11:03         ` Fam Zheng
2014-06-04 11:10           ` Paolo Bonzini
2014-06-04  9:28     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401799978-9558-6-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).