* [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function
@ 2014-06-03 17:59 Peter Maydell
2014-06-04 7:13 ` Edgar E. Iglesias
2014-06-08 11:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2014-06-03 17:59 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Edgar E. Iglesias, patches
The sign_extend() function is unused; delete it.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
We have sextract() for this these days anyway.
---
target-microblaze/translate.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
index 488df2d..50c214b 100644
--- a/target-microblaze/translate.c
+++ b/target-microblaze/translate.c
@@ -98,19 +98,6 @@ static const char *special_regnames[] =
"sr16", "sr17", "sr18"
};
-/* Sign extend at translation time. */
-static inline int sign_extend(unsigned int val, unsigned int width)
-{
- int sval;
-
- /* LSL. */
- val <<= 31 - width;
- sval = val;
- /* ASR. */
- sval >>= 31 - width;
- return sval;
-}
-
static inline void t_sync_flags(DisasContext *dc)
{
/* Synch the tb dependent flags between translator and runtime. */
--
1.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function
2014-06-03 17:59 [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function Peter Maydell
@ 2014-06-04 7:13 ` Edgar E. Iglesias
2014-06-08 11:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2014-06-04 7:13 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Tue, Jun 03, 2014 at 06:59:21PM +0100, Peter Maydell wrote:
> The sign_extend() function is unused; delete it.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Peter, feel free to push this straight in.
Thanks,
Edgar
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We have sextract() for this these days anyway.
> ---
> target-microblaze/translate.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 488df2d..50c214b 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -98,19 +98,6 @@ static const char *special_regnames[] =
> "sr16", "sr17", "sr18"
> };
>
> -/* Sign extend at translation time. */
> -static inline int sign_extend(unsigned int val, unsigned int width)
> -{
> - int sval;
> -
> - /* LSL. */
> - val <<= 31 - width;
> - sval = val;
> - /* ASR. */
> - sval >>= 31 - width;
> - return sval;
> -}
> -
> static inline void t_sync_flags(DisasContext *dc)
> {
> /* Synch the tb dependent flags between translator and runtime. */
> --
> 1.9.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-microblaze: Delete unused sign_extend() function
2014-06-03 17:59 [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function Peter Maydell
2014-06-04 7:13 ` Edgar E. Iglesias
@ 2014-06-08 11:03 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-06-08 11:03 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-trivial, Edgar E. Iglesias, patches
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-08 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-03 17:59 [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function Peter Maydell
2014-06-04 7:13 ` Edgar E. Iglesias
2014-06-08 11:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).