From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws0ao-0002CQ-7J for qemu-devel@nongnu.org; Tue, 03 Jun 2014 22:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws0af-0008Pc-Rk for qemu-devel@nongnu.org; Tue, 03 Jun 2014 22:06:18 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:42541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws0af-0008PX-Mt for qemu-devel@nongnu.org; Tue, 03 Jun 2014 22:06:09 -0400 Received: by mail-pb0-f42.google.com with SMTP id md12so6261261pbc.15 for ; Tue, 03 Jun 2014 19:06:08 -0700 (PDT) From: Ming Lei Date: Wed, 4 Jun 2014 10:05:55 +0800 Message-Id: <1401847555-8306-1-git-send-email-ming.lei@canonical.com> Subject: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature for mmio device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Ming Lei Both 'indirect_desc' and 'event_idx' are bus independent features, and they should be enabled for mmio devices too. On arm64 quad core VM(qemu-kvm), the patch can increase block I/O performance a lot with latest linux tree: - without the patch: 14K IOPS - with the patch: 34K IOPS fio script: [global] direct=1 bsrange=4k-4k timeout=10 numjobs=4 ioengine=libaio iodepth=64 filename=/dev/vdc group_reporting=1 [f1] rw=randread Cc: Peter Maydell Signed-off-by: Ming Lei --- hw/virtio/virtio-mmio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 8829eb0..18c6e5b 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -369,10 +369,16 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp) sysbus_init_mmio(sbd, &proxy->iomem); } +static Property virtio_mmio_properties[] = { + DEFINE_VIRTIO_COMMON_FEATURES(VirtIOMMIOProxy, host_features), + DEFINE_PROP_END_OF_LIST(), +}; + static void virtio_mmio_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); + dc->props = virtio_mmio_properties; dc->realize = virtio_mmio_realizefn; dc->reset = virtio_mmio_reset; set_bit(DEVICE_CATEGORY_MISC, dc->categories); -- 1.7.9.5