qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: "Alex Bligh" <alex@alex.org.uk>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	qemu-ppc@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Cornelia Huck" <cornelia.huck@de.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v3 4/4] target-ppc: Add support for new nmi() CPU callback
Date: Wed,  4 Jun 2014 18:08:50 +1000	[thread overview]
Message-ID: <1401869330-32449-5-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1401869330-32449-1-git-send-email-aik@ozlabs.ru>

This defines a nmi() callback for POWERPC CPU class so the "nmi" HMP/QMP
command gets supported for POWERPC machines.

This calls POWERPC_EXCP_RESET (vector 0x100) in the guest to deliver NMI.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Changes:
v3:
* ppc_cpu_do_nmi() is exported from excp_helper.c instead of powerpc_excp()
---
 target-ppc/cpu-qom.h        |  1 +
 target-ppc/excp_helper.c    |  8 ++++++++
 target-ppc/translate_init.c | 17 +++++++++++++++++
 3 files changed, 26 insertions(+)

diff --git a/target-ppc/cpu-qom.h b/target-ppc/cpu-qom.h
index 47dc8e6..fe7d602 100644
--- a/target-ppc/cpu-qom.h
+++ b/target-ppc/cpu-qom.h
@@ -119,6 +119,7 @@ int ppc64_cpu_write_elf64_qemunote(WriteCoreDumpFunction f,
 int ppc64_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs,
                                int cpuid, void *opaque);
 #ifndef CONFIG_USER_ONLY
+void ppc_cpu_do_nmi(CPUState *cs);
 extern const struct VMStateDescription vmstate_ppc_cpu;
 #endif
 
diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c
index a0c9fdc..11c23e7 100644
--- a/target-ppc/excp_helper.c
+++ b/target-ppc/excp_helper.c
@@ -801,6 +801,14 @@ void ppc_hw_interrupt(CPUPPCState *env)
         }
     }
 }
+
+void ppc_cpu_do_nmi(CPUState *cs)
+{
+    PowerPCCPU *cpu = POWERPC_CPU(cs);
+    CPUPPCState *env = &cpu->env;
+
+    powerpc_excp(cpu, env->excp_model, POWERPC_EXCP_RESET);
+}
 #endif /* !CONFIG_USER_ONLY */
 
 #if defined(DEBUG_OP)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 4d94015..fd24be5 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8510,6 +8510,22 @@ static void ppc_cpu_initfn(Object *obj)
     }
 }
 
+#ifndef CONFIG_USER_ONLY
+static void ppc_cpu_do_nmi_on_cpu(void *arg)
+{
+    CPUState *cs = arg;
+
+    cpu_synchronize_state(cs);
+    ppc_cpu_do_nmi(cs);
+}
+
+static int ppc_cpu_nmi(CPUState *cs)
+{
+    async_run_on_cpu(cs, ppc_cpu_do_nmi_on_cpu, cs);
+    return 0;
+}
+#endif
+
 static void ppc_cpu_class_init(ObjectClass *oc, void *data)
 {
     PowerPCCPUClass *pcc = POWERPC_CPU_CLASS(oc);
@@ -8536,6 +8552,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
 #ifdef CONFIG_USER_ONLY
     cc->handle_mmu_fault = ppc_cpu_handle_mmu_fault;
 #else
+    cc->nmi = ppc_cpu_nmi;
     cc->get_phys_page_debug = ppc_cpu_get_phys_page_debug;
     cc->vmsd = &vmstate_ppc_cpu;
 #if defined(TARGET_PPC64)
-- 
2.0.0

  parent reply	other threads:[~2014-06-04  8:09 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  8:08 [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support Alexey Kardashevskiy
2014-06-04  8:08 ` [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback Alexey Kardashevskiy
2014-06-10 13:39   ` Luiz Capitulino
2014-06-10 14:41     ` Cornelia Huck
2014-06-10 14:48       ` Luiz Capitulino
2014-06-10 16:29         ` Paolo Bonzini
2014-06-10 18:09           ` Alexander Graf
2014-06-11  0:12             ` Alexey Kardashevskiy
2014-06-11  0:21               ` Alexander Graf
2014-06-11  0:23             ` Peter Maydell
2014-06-11  0:28               ` Alexander Graf
2014-06-11  4:59                 ` Paolo Bonzini
2014-06-11  8:01                   ` Alexander Graf
2014-06-11  8:27                     ` Paolo Bonzini
2014-06-11  8:29                       ` Alexander Graf
2014-06-11  8:37                         ` Paolo Bonzini
2014-06-11  8:42                           ` Alexander Graf
2014-06-11 10:47                             ` Paolo Bonzini
2014-06-11 10:59                               ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2014-06-11 12:04                               ` [Qemu-devel] " Alexander Graf
2014-06-11  9:04                 ` Alexey Kardashevskiy
2014-06-11  9:19                   ` Alexander Graf
2014-06-11 13:10           ` Luiz Capitulino
2014-06-11 13:36             ` Cornelia Huck
2014-06-11 13:42               ` Luiz Capitulino
2014-06-11  6:50       ` Alexey Kardashevskiy
2014-06-11  7:57         ` Paolo Bonzini
2014-06-11  8:38         ` Cornelia Huck
2014-06-11  9:18           ` Cornelia Huck
2014-06-10 15:13     ` Eric Blake
2014-06-10 15:40     ` Alexey Kardashevskiy
2014-06-11 12:50       ` Luiz Capitulino
2014-06-04  8:08 ` [Qemu-devel] [PATCH v3 2/4] target-s390x: Migrate to new nmi() CPU callback Alexey Kardashevskiy
2014-06-04  8:08 ` [Qemu-devel] [PATCH v3 3/4] target-i386: " Alexey Kardashevskiy
2014-06-04  8:08 ` Alexey Kardashevskiy [this message]
2014-06-04  9:11 ` [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support Paolo Bonzini
2014-06-04  9:16 ` Peter Maydell
2014-06-04  9:30   ` Alexey Kardashevskiy
2014-06-04  9:33     ` Peter Maydell
2014-06-04  9:38       ` Alexander Graf
2014-06-04  9:39       ` Alexey Kardashevskiy
2014-06-04  9:39       ` Paolo Bonzini
2014-06-04  9:47         ` Peter Maydell
2014-06-04  9:50           ` Alexander Graf
2014-06-04 10:44             ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2014-06-04 10:51               ` Cornelia Huck
2014-06-04 11:34             ` [Qemu-devel] " Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401869330-32449-5-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=alex@alex.org.uk \
    --cc=armbru@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).