qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jidong Xiao <jidong.xiao@gmail.com>
Subject: [Qemu-devel] [PULL 11/11] kvm: Fix eax for cpuid leaf 0x40000000
Date: Wed,  4 Jun 2014 13:20:12 +0200	[thread overview]
Message-ID: <1401880812-818-12-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1401880812-818-1-git-send-email-pbonzini@redhat.com>

From: Jidong Xiao <jidong.xiao@gmail.com>

Since Linux kernel 3.5, KVM has documented eax for leaf 0x40000000
to be KVM_CPUID_FEATURES:

https://github.com/torvalds/linux/commit/57c22e5f35aa4b9b2fe11f73f3e62bbf9ef36190

But qemu still tries to set it to 0. It would be better to make qemu
and kvm consistent. This patch just fixes this issue.

Signed-off-by: Jidong Xiao <jidong.xiao@gmail.com>
[Include kvm_base in the value. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target-i386/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 40cd4b8..4bf0ac9 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -532,7 +532,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
         memcpy(signature, "KVMKVMKVM\0\0\0", 12);
         c = &cpuid_data.entries[cpuid_i++];
         c->function = KVM_CPUID_SIGNATURE | kvm_base;
-        c->eax = 0;
+        c->eax = KVM_CPUID_FEATURES | kvm_base;
         c->ebx = signature[0];
         c->ecx = signature[1];
         c->edx = signature[2];
-- 
1.8.3.1

  parent reply	other threads:[~2014-06-04 11:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 11:20 [Qemu-devel] [PULL 00/11] KVM changes for 2014-06-04 Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 01/11] kvmclock: Ensure time in migration never goes backward Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 02/11] kvm_stat: allow choosing between tracepoints and old stats Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 03/11] target-i386: Fix vm86 mode regression introduced in fd460606fd6f Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 04/11] target-i386: fix segment flags for SMM and VM86 mode Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 05/11] target-i386: rework CPL checks during task switch, preparing for next patch Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 06/11] target-i386: get CPL from SS.DPL Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 07/11] target-i386: set CC_OP to CC_OP_EFLAGS in cpu_load_eflags Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 08/11] kvm: Ensure negative return value on kvm_init() error handling path Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 09/11] kvm: Enable -cpu option to hide KVM Paolo Bonzini
2014-06-04 11:20 ` [Qemu-devel] [PULL 10/11] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation Paolo Bonzini
2014-06-04 11:20 ` Paolo Bonzini [this message]
2014-06-05 18:42 ` [Qemu-devel] [PULL 00/11] KVM changes for 2014-06-04 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401880812-818-12-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jidong.xiao@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).