* [Qemu-devel] [PATCH] target-ppc: Fix Temporary Variable Leak in bctar
@ 2014-06-04 17:26 Tom Musta
2014-06-04 21:18 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Tom Musta @ 2014-06-04 17:26 UTC (permalink / raw)
To: qemu-devel; +Cc: tommusta, qemu-ppc
Fix a temporary variable leak detected in the bctar instruction:
Opcode 13 10 11 (4d910460) leaked temporaries
Signed-off-by: Tom Musta <tommusta@gmail.com>
---
target-ppc/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 2de362c..3a8d702 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -3891,7 +3891,7 @@ static inline void gen_bcond(DisasContext *ctx, int type)
gen_update_nip(ctx, ctx->nip);
tcg_gen_exit_tb(0);
}
- if (type == BCOND_LR || type == BCOND_CTR) {
+ if (type == BCOND_LR || type == BCOND_CTR || type == BCOND_TAR) {
tcg_temp_free(target);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Fix Temporary Variable Leak in bctar
2014-06-04 17:26 [Qemu-devel] [PATCH] target-ppc: Fix Temporary Variable Leak in bctar Tom Musta
@ 2014-06-04 21:18 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2014-06-04 21:18 UTC (permalink / raw)
To: Tom Musta, qemu-devel; +Cc: qemu-ppc
On 04.06.14 19:26, Tom Musta wrote:
> Fix a temporary variable leak detected in the bctar instruction:
>
> Opcode 13 10 11 (4d910460) leaked temporaries
>
> Signed-off-by: Tom Musta <tommusta@gmail.com>
Thanks, applied to ppc-next.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-04 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 17:26 [Qemu-devel] [PATCH] target-ppc: Fix Temporary Variable Leak in bctar Tom Musta
2014-06-04 21:18 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).