qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
Date: Thu,  5 Jun 2014 09:58:46 +0800	[thread overview]
Message-ID: <1401933526-22436-9-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1401933526-22436-1-git-send-email-famz@redhat.com>

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/block/dataplane/virtio-blk.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 96068cd..323793a 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -113,7 +113,8 @@ static void do_get_id_cmd(VirtIOBlockDataPlane *s,
 static void do_rdwr_cmd(VirtIOBlockDataPlane *s, bool read,
                         struct iovec *iov, unsigned iov_cnt,
                         int64_t sector_num, VirtQueueElement *elem,
-                        struct virtio_blk_inhdr *inhdr)
+                        struct virtio_blk_inhdr *inhdr,
+                        struct virtio_blk_outhdr *outhdr)
 {
     VirtIOBlock *dev = VIRTIO_BLK(s->vdev);
     VirtIOBlockReq *req = g_slice_new0(VirtIOBlockReq);
@@ -124,6 +125,7 @@ static void do_rdwr_cmd(VirtIOBlockDataPlane *s, bool read,
     req->elem = elem;
     req->dev = dev;
     req->in = inhdr;
+    req->out = *outhdr;
     qemu_iovec_init_external(&req->qiov, iov, iov_cnt);
 
     qiov = &req->qiov;
@@ -155,13 +157,15 @@ static void complete_flush(void *opaque, int ret)
 }
 
 static void do_flush_cmd(VirtIOBlockDataPlane *s, VirtQueueElement *elem,
-                         struct virtio_blk_inhdr *inhdr)
+                         struct virtio_blk_inhdr *inhdr,
+                         struct virtio_blk_outhdr *outhdr)
 {
     VirtIOBlock *dev = VIRTIO_BLK(s->vdev);
     VirtIOBlockReq *req = g_slice_new0(VirtIOBlockReq);
     req->dev = dev;
     req->elem = elem;
     req->in = inhdr;
+    req->out = *outhdr;
 
     bdrv_aio_flush(s->blk->conf.bs, complete_flush, req);
 }
@@ -202,13 +206,13 @@ static int process_request(VirtIOBlockDataPlane *s, VirtQueueElement *elem)
     case VIRTIO_BLK_T_IN:
         do_rdwr_cmd(s, true, in_iov, in_num,
                     outhdr.sector * 512 / BDRV_SECTOR_SIZE,
-                    elem, inhdr);
+                    elem, inhdr, &outhdr);
         return 0;
 
     case VIRTIO_BLK_T_OUT:
         do_rdwr_cmd(s, false, iov, out_num,
                     outhdr.sector * 512 / BDRV_SECTOR_SIZE,
-                    elem, inhdr);
+                    elem, inhdr, &outhdr);
         return 0;
 
     case VIRTIO_BLK_T_SCSI_CMD:
@@ -216,7 +220,7 @@ static int process_request(VirtIOBlockDataPlane *s, VirtQueueElement *elem)
         return 0;
 
     case VIRTIO_BLK_T_FLUSH:
-        do_flush_cmd(s, elem, inhdr);
+        do_flush_cmd(s, elem, inhdr, &outhdr);
         return 0;
 
     case VIRTIO_BLK_T_GET_ID:
-- 
2.0.0

  parent reply	other threads:[~2014-06-05  1:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  1:58 [Qemu-devel] [PATCH v2 0/8] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 1/8] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 2/8] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 3/8] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 4/8] virtio-blk: Drop VirtIOBlockRequest.read Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 5/8] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq Fam Zheng
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 6/8] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr Fam Zheng
2014-06-05  2:51   ` Paolo Bonzini
2014-06-05  1:58 ` [Qemu-devel] [PATCH v2 7/8] virtio-blk: Convert VirtIOBlockReq.out to structrue Fam Zheng
2014-06-05  2:54   ` Paolo Bonzini
2014-06-05  1:58 ` Fam Zheng [this message]
2014-06-05  2:55   ` [Qemu-devel] [PATCH v2 8/8] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code Paolo Bonzini
2014-06-05  3:50     ` Fam Zheng
2014-06-05  4:09       ` Paolo Bonzini
2014-06-05  9:20         ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401933526-22436-9-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).