From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsTrz-0003V6-8G for qemu-devel@nongnu.org; Thu, 05 Jun 2014 05:22:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsTrr-0008CJ-4q for qemu-devel@nongnu.org; Thu, 05 Jun 2014 05:21:59 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:34691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsTrq-0008Bc-SS for qemu-devel@nongnu.org; Thu, 05 Jun 2014 05:21:51 -0400 From: Chunyan Liu Date: Thu, 5 Jun 2014 17:20:52 +0800 Message-Id: <1401960072-2363-14-git-send-email-cyliu@suse.com> In-Reply-To: <1401960072-2363-1-git-send-email-cyliu@suse.com> References: <1401960072-2363-1-git-send-email-cyliu@suse.com> Subject: [Qemu-devel] [PATCH v28 13/33] vvfat.c: handle cross_driver's create_options and create_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com vvfat shares create options of qcow driver. To avoid vvfat breaking when qcow driver changes from QEMUOptionParameter to QemuOpts, let it able to handle both cases. Signed-off-by: Chunyan Liu Reviewed-by: Eric Blake --- block/vvfat.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index d895582..b1ab195 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2910,8 +2910,9 @@ static BlockDriver vvfat_write_target = { static int enable_write_target(BDRVVVFATState *s, Error **errp) { - BlockDriver *bdrv_qcow; - QEMUOptionParameter *options; + BlockDriver *bdrv_qcow = NULL; + QemuOptsList *create_opts = NULL; + QemuOpts *opts = NULL; int ret; int size = sector2cluster(s, s->sector_count); s->used_clusters = calloc(size, 1); @@ -2926,12 +2927,21 @@ static int enable_write_target(BDRVVVFATState *s, Error **errp) } bdrv_qcow = bdrv_find_format("qcow"); - options = parse_option_parameters("", bdrv_qcow->create_options, NULL); - set_option_parameter_int(options, BLOCK_OPT_SIZE, s->sector_count * 512); - set_option_parameter(options, BLOCK_OPT_BACKING_FILE, "fat:"); + assert(!(bdrv_qcow->create_opts && bdrv_qcow->create_options)); + if (bdrv_qcow->create_options) { + create_opts = params_to_opts(bdrv_qcow->create_options); + } else { + create_opts = bdrv_qcow->create_opts; + } + opts = qemu_opts_create(create_opts, NULL, 0, &error_abort); + qemu_opt_set_number(opts, BLOCK_OPT_SIZE, s->sector_count * 512); + qemu_opt_set(opts, BLOCK_OPT_BACKING_FILE, "fat:"); - ret = bdrv_create(bdrv_qcow, s->qcow_filename, options, NULL, errp); - free_option_parameters(options); + ret = bdrv_create(bdrv_qcow, s->qcow_filename, NULL, opts, errp); + qemu_opts_del(opts); + if (bdrv_qcow->create_options) { + qemu_opts_free(create_opts); + } if (ret < 0) { goto err; } -- 1.7.12.4