From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v28 23/33] raw-win32.c: replace QEMUOptionParameter with QemuOpts
Date: Thu, 5 Jun 2014 17:21:02 +0800 [thread overview]
Message-ID: <1401960072-2363-24-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1401960072-2363-1-git-send-email-cyliu@suse.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
block/raw-win32.c | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 064ea31..e5ac297 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -478,8 +478,7 @@ static int64_t raw_get_allocated_file_size(BlockDriverState *bs)
return st.st_size;
}
-static int raw_create(const char *filename, QEMUOptionParameter *options,
- Error **errp)
+static int raw_create(const char *filename, QemuOpts *opts, Error **errp)
{
int fd;
int64_t total_size = 0;
@@ -487,12 +486,8 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
strstart(filename, "file:", &filename);
/* Read out options */
- while (options && options->name) {
- if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
- total_size = options->value.n / 512;
- }
- options++;
- }
+ total_size =
+ qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / 512;
fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
@@ -506,13 +501,18 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
return 0;
}
-static QEMUOptionParameter raw_create_options[] = {
- {
- .name = BLOCK_OPT_SIZE,
- .type = OPT_SIZE,
- .help = "Virtual disk size"
- },
- { NULL }
+
+static QemuOptsList raw_create_opts = {
+ .name = "raw-create-opts",
+ .head = QTAILQ_HEAD_INITIALIZER(raw_create_opts.head),
+ .desc = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = QEMU_OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { /* end of list */ }
+ }
};
static BlockDriver bdrv_file = {
@@ -521,9 +521,9 @@ static BlockDriver bdrv_file = {
.instance_size = sizeof(BDRVRawState),
.bdrv_needs_filename = true,
.bdrv_parse_filename = raw_parse_filename,
- .bdrv_file_open = raw_open,
- .bdrv_close = raw_close,
- .bdrv_create = raw_create,
+ .bdrv_file_open = raw_open,
+ .bdrv_close = raw_close,
+ .bdrv_create2 = raw_create,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_aio_readv = raw_aio_readv,
@@ -535,7 +535,7 @@ static BlockDriver bdrv_file = {
.bdrv_get_allocated_file_size
= raw_get_allocated_file_size,
- .create_options = raw_create_options,
+ .create_opts = &raw_create_opts,
};
/***********************************************/
--
1.7.12.4
next prev parent reply other threads:[~2014-06-05 9:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 9:20 [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 01/33] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 03/33] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 04/33] qapi: output def_value_str when query command line options Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 05/33] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 06/33] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 11/33] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 12/33] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 13/33] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 14/33] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 15/33] gluster.c: " Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 16/33] iscsi.c: " Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 17/33] nfs.c: " Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 18/33] qcow.c: " Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 19/33] QemuOpts: export qemu_opt_find Chunyan Liu
2014-06-05 9:20 ` [Qemu-devel] [PATCH v28 20/33] qcow2.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 21/33] qed.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 22/33] raw-posix.c: " Chunyan Liu
2014-06-05 9:21 ` Chunyan Liu [this message]
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 24/33] raw_bsd.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 25/33] rbd.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 26/33] sheepdog.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 27/33] ssh.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 28/33] vdi.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 29/33] vhdx.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 30/33] vmdk.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 31/33] vpc.c: " Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 32/33] cleanup QEMUOptionParameter Chunyan Liu
2014-06-05 9:21 ` [Qemu-devel] [PATCH v28 33/33] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList Chunyan Liu
2014-06-05 13:28 ` [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts Stefan Hajnoczi
2014-06-05 13:45 ` Markus Armbruster
2014-06-09 3:08 ` Chun Yan Liu
2014-06-09 13:31 ` Stefan Hajnoczi
2014-06-09 13:31 ` Stefan Hajnoczi
2014-06-11 18:00 ` Stefan Hajnoczi
2014-06-12 7:06 ` Markus Armbruster
2014-06-23 14:06 ` Peter Lieven
2014-06-26 5:01 ` Chun Yan Liu
2014-06-26 7:19 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401960072-2363-24-git-send-email-cyliu@suse.com \
--to=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).