From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsXr7-0001Mk-Th for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:37:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsXr1-0004CR-Tk for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsXr1-0004CB-Mb for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:37:15 -0400 From: Kevin Wolf Date: Thu, 5 Jun 2014 15:36:32 +0200 Message-Id: <1401975393-7255-21-git-send-email-kwolf@redhat.com> In-Reply-To: <1401975393-7255-1-git-send-email-kwolf@redhat.com> References: <1401975393-7255-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v4 20/21] mirror: Handle failure for potentially large allocations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, stefanha@redhat.com Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the mirror block job. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Benoit Canet --- block/mirror.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 94c8661..07417d7 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -350,7 +350,12 @@ static void coroutine_fn mirror_run(void *opaque) } end = s->common.len >> BDRV_SECTOR_BITS; - s->buf = qemu_blockalign(bs, s->buf_size); + s->buf = qemu_try_blockalign(bs, s->buf_size); + if (s->buf == NULL) { + ret = -ENOMEM; + goto immediate_exit; + } + sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS; mirror_free_init(s); -- 1.8.3.1