From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsY8u-0005EY-BU for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:55:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsY8m-0004la-RR for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:55:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsY8m-0004lS-Ju for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:55:36 -0400 From: Kevin Wolf Date: Thu, 5 Jun 2014 15:55:27 +0200 Message-Id: <1401976527-10131-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] rbd: Fix leaks in rbd_start_aio() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, stefanha@redhat.com, josh.durgin@inktank.com Signed-off-by: Kevin Wolf --- block/rbd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/rbd.c b/block/rbd.c index 09af484..94e2bfd 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -684,13 +684,16 @@ static BlockDriverAIOCB *rbd_start_aio(BlockDriverState *bs, } if (r < 0) { - goto failed; + goto failed_completion; } return &acb->common; +failed_completion: + rbd_aio_release(c); failed: g_free(rcb); + g_free(acb->bounce); qemu_aio_release(acb); return NULL; } -- 1.8.3.1