From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, arei.gonglei@huawei.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v3 1/4] virtio-blk-test.c: change pci_nop() to virtblk_init()
Date: Fri, 6 Jun 2014 09:11:57 +0800 [thread overview]
Message-ID: <1402017120-27655-2-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1402017120-27655-1-git-send-email-akong@redhat.com>
I want to add a new subtest in virtio-blk-test.c, it will start
guest without network. The original pci_init() did nothing, but
it's good to reserve a very simple initialization testing.
Signed-off-by: Amos Kong <akong@redhat.com>
---
tests/virtio-blk-test.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
index d53f875..0fdec01 100644
--- a/tests/virtio-blk-test.c
+++ b/tests/virtio-blk-test.c
@@ -12,9 +12,12 @@
#include "libqtest.h"
#include "qemu/osdep.h"
-/* Tests only initialization so far. TODO: Replace with functional tests */
-static void pci_nop(void)
+/* Tests only initialization */
+static void virtblk_init(void)
{
+ qtest_start("-drive id=drv0,if=none,file=/dev/null "
+ "-device virtio-blk-pci,drive=drv0");
+ qtest_end();
}
int main(int argc, char **argv)
@@ -22,13 +25,9 @@ int main(int argc, char **argv)
int ret;
g_test_init(&argc, &argv, NULL);
- qtest_add_func("/virtio/blk/pci/nop", pci_nop);
+ qtest_add_func("/virtio/blk/pci/init", virtblk_init);
- qtest_start("-drive id=drv0,if=none,file=/dev/null "
- "-device virtio-blk-pci,drive=drv0");
ret = g_test_run();
- qtest_end();
-
return ret;
}
--
1.9.3
next prev parent reply other threads:[~2014-06-06 1:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 1:11 [Qemu-devel] [PATCH v3 0/4] test virtio-blk hotplug Amos Kong
2014-06-06 1:11 ` Amos Kong [this message]
2014-06-06 13:20 ` [Qemu-devel] [PATCH v3 1/4] virtio-blk-test.c: change pci_nop() to virtblk_init() Stefan Hajnoczi
2014-06-06 1:11 ` [Qemu-devel] [PATCH v3 2/4] qtest: introduce qmp_exec_hmp_cmd() Amos Kong
2014-06-06 13:20 ` Stefan Hajnoczi
2014-06-06 1:11 ` [Qemu-devel] [PATCH v3 3/4] virtio-blk-test.c: add hotplug subtest Amos Kong
2014-06-06 1:28 ` Gonglei (Arei)
2014-06-06 5:29 ` Amos Kong
2014-06-06 8:05 ` Gonglei (Arei)
2014-06-06 8:23 ` Amos Kong
2014-06-06 9:31 ` Gonglei (Arei)
2014-06-06 10:10 ` Amos Kong
2014-06-06 10:27 ` Gonglei (Arei)
2014-06-06 13:20 ` Stefan Hajnoczi
2014-06-06 1:12 ` [Qemu-devel] [PATCH v3 4/4] qtest: use qmp_exec_hmp_cmd() in blockdev-test Amos Kong
2014-06-06 13:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402017120-27655-2-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).