qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@linaro.org>
Subject: [Qemu-devel] [PATCH v2 00/13] linux-user: __{get, put}_user return value cleanup
Date: Fri,  6 Jun 2014 12:46:44 +0300	[thread overview]
Message-ID: <1402048017-30604-1-git-send-email-riku.voipio@linaro.org> (raw)

From: Riku Voipio <riku.voipio@linaro.org>

This series is a cleanup and gcc-4.9 buildfix:

linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no 
effect [-Werror=unused-value]
      ((hptr), (x)), 0)

removing the unused 0 moves the bar:

linux-user/main.c: In function ‘arm_kernel_cmpxchg64_helper’:
linux-user/qemu.h:330:15: error: void value not ignored as it ought to be
         __ret = __put_user((x), __hptr);    \

And after fixing that, we see there is a lot of reading the return
value of __put_user and __get_user in signal.c. A lot of this code
has been copied from kernel, where the accessor functions might fail
Qemu uses different model of accessing. Access is already checked in
lock_user(), and thus __put/__get user cannot fail.

So this patchset clears signal.c from reading __get_user and
__put_user return values, and then fixes the definitions of the macros.

Riku

Riku Voipio (13):
  signal/all: remove __get/__put_user return value reading
  signal/x86/setup_frame: __put_user cleanup
  signal/all: remove return value from copy_siginfo_to_user
  signal/all: remove return value from setup_sigcontext
  signal/all: remove return value from restore_sigcontext
  signal/sparc/restore_fpu_state: remove
  signal/all/do_sigaltstack remove __get_user value check
  signal/all/do_sigreturn - remove __get_user checks
  signal/all/setup_frame remove __put_user checks
  signal/ppc/{save,restore}_user_regs remove __put/get error checks
  signal/sparc64_set_context: remove __get_user checks
  signal/ppc/do_setcontext remove __get_user return check
  linux-user: fix gcc-4.9 compiler error on __{get,put]}_user

 linux-user/qemu.h   |   12 +-
 linux-user/signal.c | 1249 +++++++++++++++++++++------------------------------
 2 files changed, 513 insertions(+), 748 deletions(-)

-- 
2.0.0.rc2

             reply	other threads:[~2014-06-06  9:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  9:46 riku.voipio [this message]
2014-06-07 21:40 ` [Qemu-devel] [PATCH v2 00/13] linux-user: __{get, put}_user return value cleanup Peter Maydell
2014-06-09 12:25   ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402048017-30604-1-git-send-email-riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).