From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsqjt-0006Fo-GN for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:47:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsqjm-0001Wi-97 for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:47:09 -0400 Received: from afflict.kos.to ([92.243.29.197]:38372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsqjm-0001WG-2B for qemu-devel@nongnu.org; Fri, 06 Jun 2014 05:47:02 -0400 From: riku.voipio@linaro.org Date: Fri, 6 Jun 2014 12:46:51 +0300 Message-Id: <1402048017-30604-8-git-send-email-riku.voipio@linaro.org> Subject: [Qemu-devel] [PATCH v2 07/13] signal/all/do_sigaltstack remove __get_user value check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio From: Riku Voipio Access is already checked in the lock_user_struct call before. Signed-off-by: Riku Voipio --- linux-user/signal.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 91fd27f..56d6e29 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -619,11 +619,12 @@ abi_long do_sigaltstack(abi_ulong uss_addr, abi_ulong uoss_addr, abi_ulong sp) struct target_sigaltstack ss; ret = -TARGET_EFAULT; - if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1) - || __get_user(ss.ss_sp, &uss->ss_sp) - || __get_user(ss.ss_size, &uss->ss_size) - || __get_user(ss.ss_flags, &uss->ss_flags)) + if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1)) { goto out; + } + __get_user(ss.ss_sp, &uss->ss_sp); + __get_user(ss.ss_size, &uss->ss_size); + __get_user(ss.ss_flags, &uss->ss_flags); unlock_user_struct(uss, uss_addr, 0); ret = -TARGET_EPERM; -- 2.0.0.rc2