qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] block/qapi: Give some functions internal linkage
Date: Fri,  6 Jun 2014 14:51:00 +0200	[thread overview]
Message-ID: <1402059060-17544-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1402059060-17544-1-git-send-email-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 block/qapi.c         | 13 ++++++-------
 include/block/qapi.h |  7 -------
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/block/qapi.c b/block/qapi.c
index 97e1641..f420e9a 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -89,9 +89,9 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs)
  * information, or NULL because there are no snapshots.  Returns -errno on
  * error, with *p_list untouched.
  */
-int bdrv_query_snapshot_info_list(BlockDriverState *bs,
-                                  SnapshotInfoList **p_list,
-                                  Error **errp)
+static int bdrv_query_snapshot_info_list(BlockDriverState *bs,
+                                         SnapshotInfoList **p_list,
+                                         Error **errp)
 {
     int i, sn_count;
     QEMUSnapshotInfo *sn_tab = NULL;
@@ -236,9 +236,8 @@ void bdrv_query_image_info(BlockDriverState *bs,
 }
 
 /* @p_info will be set only on success. */
-void bdrv_query_info(BlockDriverState *bs,
-                     BlockInfo **p_info,
-                     Error **errp)
+static void bdrv_query_info(BlockDriverState *bs, BlockInfo **p_info,
+                            Error **errp)
 {
     BlockInfo *info = g_malloc0(sizeof(*info));
     BlockDriverState *bs0;
@@ -293,7 +292,7 @@ void bdrv_query_info(BlockDriverState *bs,
     qapi_free_BlockInfo(info);
 }
 
-BlockStats *bdrv_query_stats(const BlockDriverState *bs)
+static BlockStats *bdrv_query_stats(const BlockDriverState *bs)
 {
     BlockStats *s;
 
diff --git a/include/block/qapi.h b/include/block/qapi.h
index e92c00d..6672179 100644
--- a/include/block/qapi.h
+++ b/include/block/qapi.h
@@ -30,16 +30,9 @@
 #include "block/snapshot.h"
 
 BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs);
-int bdrv_query_snapshot_info_list(BlockDriverState *bs,
-                                  SnapshotInfoList **p_list,
-                                  Error **errp);
 void bdrv_query_image_info(BlockDriverState *bs,
                            ImageInfo **p_info,
                            Error **errp);
-void bdrv_query_info(BlockDriverState *bs,
-                     BlockInfo **p_info,
-                     Error **errp);
-BlockStats *bdrv_query_stats(const BlockDriverState *bs);
 
 void bdrv_snapshot_dump(fprintf_function func_fprintf, void *f,
                         QEMUSnapshotInfo *sn);
-- 
1.9.3

  parent reply	other threads:[~2014-06-06 12:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 12:50 [Qemu-devel] [PATCH 0/3] block: Minor cleanups Markus Armbruster
2014-06-06 12:50 ` [Qemu-devel] [PATCH 1/3] blockdev: Rename drive_init(), drive_uninit() to drive_new(), drive_del() Markus Armbruster
2014-06-06 14:05   ` Benoît Canet
2014-06-06 16:13     ` Markus Armbruster
2014-06-06 12:50 ` [Qemu-devel] [PATCH 2/3] blockdev: Remove unused DriveInfo reference count Markus Armbruster
2014-06-06 14:09   ` Benoît Canet
2014-06-06 12:51 ` Markus Armbruster [this message]
2014-06-06 14:13   ` [Qemu-devel] [PATCH 3/3] block/qapi: Give some functions internal linkage Benoît Canet
2014-06-13 13:15   ` Stefan Hajnoczi
2014-06-11 10:36 ` [Qemu-devel] [PATCH 0/3] block: Minor cleanups Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402059060-17544-4-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).