From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH] vdi: remove double conversion
Date: Fri, 6 Jun 2014 16:06:52 +0200 [thread overview]
Message-ID: <1402063613-12400-1-git-send-email-pbonzini@redhat.com> (raw)
This should be a problem when running on big-endian machines.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
It's time to clean up old branch, and I found this nice little
patch from May 2012.
block/vdi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/vdi.c b/block/vdi.c
index 119d3c7..993430e 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -237,7 +237,6 @@ static void vdi_header_to_le(VdiHeader *header)
cpu_to_le32s(&header->block_extra);
cpu_to_le32s(&header->blocks_in_image);
cpu_to_le32s(&header->blocks_allocated);
- cpu_to_le32s(&header->blocks_allocated);
uuid_convert(header->uuid_image);
uuid_convert(header->uuid_last_snap);
uuid_convert(header->uuid_link);
--
1.8.3.1
next reply other threads:[~2014-06-06 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:06 Paolo Bonzini [this message]
2014-06-06 14:06 ` [Qemu-devel] [PATCH] x86: correctly implement soft reset Paolo Bonzini
2014-06-06 14:53 ` Paolo Bonzini
2014-06-08 13:15 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-06-21 15:12 ` Michael Tokarev
2014-06-23 11:50 ` Paolo Bonzini
2014-06-06 14:14 ` [Qemu-devel] [PATCH] vdi: remove double conversion Benoît Canet
2014-06-08 14:43 ` Stefan Weil
2014-06-08 13:14 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402063613-12400-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).