From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsvDm-0001Z9-7K for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsvDe-0001Rb-LQ for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:34:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsvDe-0001QO-DO for qemu-devel@nongnu.org; Fri, 06 Jun 2014 10:34:10 -0400 From: Amos Kong Date: Fri, 6 Jun 2014 22:33:53 +0800 Message-Id: <1402065233-31894-5-git-send-email-akong@redhat.com> In-Reply-To: <1402065233-31894-1-git-send-email-akong@redhat.com> References: <1402065233-31894-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH v4 4/4] qtest: use qmp_exec_hmp_cmd() in blockdev-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, arei.gonglei@huawei.com, afaerber@suse.de Signed-off-by: Amos Kong Reviewed-by: Stefan Hajnoczi --- tests/blockdev-test.c | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/tests/blockdev-test.c b/tests/blockdev-test.c index c940e00..c9127c0 100644 --- a/tests/blockdev-test.c +++ b/tests/blockdev-test.c @@ -16,35 +16,16 @@ static void test_drive_add_empty(void) { - QDict *response; - const char *response_return; - /* Start with an empty drive */ qtest_start("-drive if=none,id=drive0"); /* Delete the drive */ - response = qmp("{\"execute\": \"human-monitor-command\"," - " \"arguments\": {" - " \"command-line\": \"drive_del drive0\"" - "}}"); - g_assert(response); - response_return = qdict_get_try_str(response, "return"); - g_assert(response_return); - g_assert(strcmp(response_return, "") == 0); - QDECREF(response); + qmp_exec_hmp_cmd("", "drive_del drive0"); /* Ensure re-adding the drive works - there should be no duplicate ID error * because the old drive must be gone. */ - response = qmp("{\"execute\": \"human-monitor-command\"," - " \"arguments\": {" - " \"command-line\": \"drive_add 0 if=none,id=drive0\"" - "}}"); - g_assert(response); - response_return = qdict_get_try_str(response, "return"); - g_assert(response_return); - g_assert(strcmp(response_return, "OK\r\n") == 0); - QDECREF(response); + qmp_exec_hmp_cmd("OK\r\n", "drive_add 0 if=none,id=drive0"); qtest_end(); } -- 1.9.3