From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsx7O-0007D5-5O for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:35:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsx7H-0003q6-Ou for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:35:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsx7H-0003py-FW for qemu-devel@nongnu.org; Fri, 06 Jun 2014 12:35:43 -0400 From: Markus Armbruster Date: Fri, 6 Jun 2014 18:35:13 +0200 Message-Id: <1402072513-7001-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] audio: Drop superfluous conditionals around g_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: av1474@comtv.ru, kraxel@redhat.com Signed-off-by: Markus Armbruster --- audio/alsaaudio.c | 12 ++++-------- audio/audio_template.h | 15 ++++----------- audio/ossaudio.c | 6 ++---- hw/audio/adlib.c | 4 +--- 4 files changed, 11 insertions(+), 26 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index e4e5442..74ead97 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -815,10 +815,8 @@ static void alsa_fini_out (HWVoiceOut *hw) ldebug ("alsa_fini\n"); alsa_anal_close (&alsa->handle, &alsa->pollhlp); - if (alsa->pcm_buf) { - g_free (alsa->pcm_buf); - alsa->pcm_buf = NULL; - } + g_free(alsa->pcm_buf); + alsa->pcm_buf = NULL; } static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) @@ -978,10 +976,8 @@ static void alsa_fini_in (HWVoiceIn *hw) alsa_anal_close (&alsa->handle, &alsa->pollhlp); - if (alsa->pcm_buf) { - g_free (alsa->pcm_buf); - alsa->pcm_buf = NULL; - } + g_free(alsa->pcm_buf); + alsa->pcm_buf = NULL; } static int alsa_run_in (HWVoiceIn *hw) diff --git a/audio/audio_template.h b/audio/audio_template.h index 16f7880..8173188 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -71,10 +71,7 @@ static void glue (audio_init_nb_voices_, TYPE) (struct audio_driver *drv) static void glue (audio_pcm_hw_free_resources_, TYPE) (HW *hw) { - if (HWBUF) { - g_free (HWBUF); - } - + g_free (HWBUF); HWBUF = NULL; } @@ -92,9 +89,7 @@ static int glue (audio_pcm_hw_alloc_resources_, TYPE) (HW *hw) static void glue (audio_pcm_sw_free_resources_, TYPE) (SW *sw) { - if (sw->buf) { - g_free (sw->buf); - } + g_free (sw->buf); if (sw->rate) { st_rate_stop (sw->rate); @@ -172,10 +167,8 @@ static int glue (audio_pcm_sw_init_, TYPE) ( static void glue (audio_pcm_sw_fini_, TYPE) (SW *sw) { glue (audio_pcm_sw_free_resources_, TYPE) (sw); - if (sw->name) { - g_free (sw->name); - sw->name = NULL; - } + g_free (sw->name); + sw->name = NULL; } static void glue (audio_pcm_hw_add_sw_, TYPE) (HW *hw, SW *sw) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 5a73716..4db2ca6 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -736,10 +736,8 @@ static void oss_fini_in (HWVoiceIn *hw) oss_anal_close (&oss->fd); - if (oss->pcm_buf) { - g_free (oss->pcm_buf); - oss->pcm_buf = NULL; - } + g_free(oss->pcm_buf); + oss->pcm_buf = NULL; } static int oss_run_in (HWVoiceIn *hw) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 5dd739e..656eb37 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -275,9 +275,7 @@ static void Adlib_fini (AdlibState *s) } #endif - if (s->mixbuf) { - g_free (s->mixbuf); - } + g_free(s->mixbuf); s->active = 0; s->enabled = 0; -- 1.9.3