From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v2 2/2] vnc: Drop superfluous conditionals around g_strdup()
Date: Fri, 6 Jun 2014 18:47:44 +0200 [thread overview]
Message-ID: <1402073264-9606-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1402073264-9606-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
ui/vnc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index d771a2c..6c9d4f3 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3009,10 +3009,7 @@ int vnc_display_password(DisplayState *ds, const char *password)
}
g_free(vs->password);
- vs->password = NULL;
- if (password) {
- vs->password = g_strdup(password);
- }
+ vs->password = g_strdup(password);
return 0;
}
--
1.9.3
next prev parent reply other threads:[~2014-06-06 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 16:47 [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Markus Armbruster
2014-06-06 16:47 ` [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 17:02 ` Eric Blake
2014-06-06 17:11 ` Markus Armbruster
2014-06-10 8:03 ` Gerd Hoffmann
2014-06-06 16:47 ` Markus Armbruster [this message]
2014-06-06 17:03 ` [Qemu-devel] [PATCH v2 2/2] vnc: Drop superfluous conditionals around g_strdup() Eric Blake
2014-06-12 11:40 ` [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Gerd Hoffmann
2014-06-12 12:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402073264-9606-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).