From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtMxX-00077w-WD for qemu-devel@nongnu.org; Sat, 07 Jun 2014 16:11:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtMxX-0000kl-44 for qemu-devel@nongnu.org; Sat, 07 Jun 2014 16:11:23 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:48553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtMxW-0000kO-TB for qemu-devel@nongnu.org; Sat, 07 Jun 2014 16:11:23 -0400 From: Peter Maydell Date: Sat, 7 Jun 2014 21:11:21 +0100 Message-Id: <1402171881-14343-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> References: <1402171881-14343-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 3/3] target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org In handle_simd_shift_fpint_conv(), the combination of is_double == true, is_scalar == false and is_q == false is an unallocated encoding; the 'both parts false' case of the nested ?: expression for calculating maxpass is therefore unreachable and can be removed. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 4c9e237..5542d7d 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -6484,7 +6484,7 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar, tcg_shift = tcg_const_i32(fracbits); if (is_double) { - int maxpass = is_scalar ? 1 : is_q ? 2 : 1; + int maxpass = is_scalar ? 1 : 2; for (pass = 0; pass < maxpass; pass++) { TCGv_i64 tcg_op = tcg_temp_new_i64(); -- 1.8.5.4