From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sbruno@ignoranthack.me>) id 1WtPEA-0000e0-2U
	for qemu-devel@nongnu.org; Sat, 07 Jun 2014 18:36:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sbruno@ignoranthack.me>) id 1WtPE4-00047w-5g
	for qemu-devel@nongnu.org; Sat, 07 Jun 2014 18:36:42 -0400
Received: from ignoranthack.me ([199.102.79.106]:56445
	helo=mail.ignoranthack.me) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sbruno@ignoranthack.me>) id 1WtPE4-00047o-10
	for qemu-devel@nongnu.org; Sat, 07 Jun 2014 18:36:36 -0400
From: Sean Bruno <sbruno@ignoranthack.me>
In-Reply-To: <CAFEAcA_YsmyR=Da9sGxgXa9072ff4Q8nO_KM2JXrBtgqPRDF0A@mail.gmail.com>
References: <1402062579-28716-1-git-send-email-sbruno@freebsd.org>
	<1402062579-28716-7-git-send-email-sbruno@freebsd.org>
	<CAFEAcA_YsmyR=Da9sGxgXa9072ff4Q8nO_KM2JXrBtgqPRDF0A@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Date: Sat, 07 Jun 2014 15:36:33 -0700
Message-ID: <1402180593.1438.5.camel@bruno>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/9 v3] FreeBSD-user: Add __acl_* to the
 table of syscalls
Reply-To: sbruno@freebsd.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Sat, 2014-06-07 at 23:08 +0100, Peter Maydell wrote:
> On 6 June 2014 14:49, Sean Bruno <sbruno@freebsd.org> wrote:
> > Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> 
> Commit message needs tweaking to be clearer that we're
> only adding strace support for syscalls here, not implementing
> new syscalls.
> 
> > ---
> >  bsd-user/freebsd/strace.list | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list
> > index 32b3c55..b09b130 100644
> > --- a/bsd-user/freebsd/strace.list
> > +++ b/bsd-user/freebsd/strace.list
> > @@ -16,6 +16,18 @@
> >   *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> >   */
> >
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_fd, "__acl_get_fd", "%s(%d, %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_aclcheck_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> 
> Printed strings don't match syscall names -- cut and paste error?
> (You should probably also check the parameter format strings are
> correct, since the names are wrong.)

Indeed, this is totally a bug/typo in the code.  Will fix.

> 
> > +{ TARGET_FREEBSD_NR___acl_delete_fd, "__acl_delete_fd", "%s(%d, %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_delete_file, "__acl_delete_file", "%s(\"%s\", %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_delete_link, "__acl_delete_link", "%s(\"%s\", %d)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_fd, "__acl_get_fd", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_get_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_fd, "__acl_get_fd", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_file, "__acl_get_file", "%s(\"%s\", %d, %#x)", NULL, NULL },
> > +{ TARGET_FREEBSD_NR___acl_set_link, "__acl_get_link", "%s(\"%s\", %d, %#x)", NULL, NULL },
> 
> More cut-n-paste errors I think.
> 
> thanks
> -- PMM

Same here, I'll need to retest and resubmit this one for sure.

sean