qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic
Date: Sun, 08 Jun 2014 11:30:55 +0100	[thread overview]
Message-ID: <1402223455.15729.185.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1400756406-22617-3-git-send-email-kraxel@redhat.com>

On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote:
> Have a global timer.  Update all visible terminal windows syncronously.
> Right now this can be the active_console only, but that will change
> soon.  The global timer will disable itself if not needed, so we only
> have to care start it if needed.  Which might be at console switch time
> or when a new displaychangelistener is registered.

Running current master (d7d3d6092cb7) I'm seeing a segmentation fault
while running:
        ./aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57
        -sdl
which goes away if I revert this patch. qemu is configured with
        ./configure --target-list=aarch64-softmmu  --enable-sdl

The backtrace shows that the timer is NULL.

Program received signal SIGSEGV, Segmentation fault.
0x0000555555778204 in timer_mod (ts=0x0, expire_time=662170703) at qemu-timer.c:442
442	    timer_mod_ns(ts, expire_time * ts->scale);
(gdb) bt
#0  0x0000555555778204 in timer_mod (ts=0x0, expire_time=662170703) at qemu-timer.c:442
#1  0x0000555555796130 in text_console_update_cursor_timer () at ui/console.c:1703
#2  text_console_update_cursor (opaque=opaque@entry=0x0) at ui/console.c:1725
#3  0x0000555555798feb in register_displaychangelistener (dcl=<optimized out>) at ui/console.c:1316
#4  0x00005555557a250f in sdl_display_init (ds=ds@entry=0x5555564c0d00, full_screen=-446133248, no_frame=<optimized out>)
    at ui/sdl.c:946
#5  0x00005555555f50a7 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at vl.c:4475

Cheers,
Ian.

  reply	other threads:[~2014-06-08 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 11:00 [Qemu-devel] [PATCH 0/3] console: text terminal updates Gerd Hoffmann
2014-05-22 11:00 ` [Qemu-devel] [PATCH 1/3] console: update text terminal surface unconditionally Gerd Hoffmann
2014-05-22 11:00 ` [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic Gerd Hoffmann
2014-06-08 10:30   ` Ian Campbell [this message]
2014-06-10  7:44     ` Gerd Hoffmann
2014-06-11  9:59       ` Ian Campbell
2014-05-22 11:00 ` [Qemu-devel] [PATCH 3/3] console: add kbd_put_keysym_console Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402223455.15729.185.camel@hastur.hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=aliguori@amazon.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).