From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtvNS-0003bY-Uo for qemu-devel@nongnu.org; Mon, 09 Jun 2014 04:56:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WtvNM-0002v6-5E for qemu-devel@nongnu.org; Mon, 09 Jun 2014 04:56:26 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:38163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WtvNL-0002um-VC for qemu-devel@nongnu.org; Mon, 09 Jun 2014 04:56:20 -0400 Received: by mail-wi0-f170.google.com with SMTP id bs8so3731918wib.1 for ; Mon, 09 Jun 2014 01:56:19 -0700 (PDT) From: =?UTF-8?q?Marc=20Mar=C3=AD?= Date: Mon, 9 Jun 2014 10:55:32 +0200 Message-Id: <1402304133-29620-3-git-send-email-marc.mari.barcelo@gmail.com> In-Reply-To: <1402304133-29620-1-git-send-email-marc.mari.barcelo@gmail.com> References: <1402304133-29620-1-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/3] x86 piix4: Correct SMBus base address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc=20Mar=C3=AD?= , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Stefan Hajnoczi As defined in the PIIX4 datasheet in page 135, the base address is set on bits [15:4]. The mask was changed to match those bits. Datasheet: http://www.intel.com/assets/pdf/datasheet/290562.pdf Found by Stefan Hajnoczi Signed-off-by: Marc Marí --- hw/acpi/piix4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 67dc075..5f263da 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -133,7 +133,7 @@ static void smbus_io_space_update(PIIX4PMState *s) PCIDevice *d = PCI_DEVICE(s); s->smb_io_base = le32_to_cpu(*(uint32_t *)(d->config + 0x90)); - s->smb_io_base &= 0xffc0; + s->smb_io_base &= 0xfff0; memory_region_transaction_begin(); memory_region_set_enabled(&s->smb.io, d->config[0xd2] & 1); -- 1.7.10.4