qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Jiri Pirko <jiri@resnulli.us>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 2/5] vmxnet3: fix msix vectors unuse
Date: Mon,  9 Jun 2014 15:43:03 +0200	[thread overview]
Message-ID: <1402321386-17773-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1402321386-17773-1-git-send-email-stefanha@redhat.com>

From: Jiri Pirko <jiri@resnulli.us>

In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
VMXNET3_MAX_INTRS. That is not correct since vector of
value VMXNET3_MAX_INTRS was never used. Also all the used vectors
are not un-used. So call vmxnet3_unuse_msix_vectors() instead which
does the correct job.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Dmitry Fleytman <dmitry@daynix.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/net/vmxnet3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 1bb9259..f3be494 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s)
     PCIDevice *d = PCI_DEVICE(s);
 
     if (s->msix_used) {
-        msix_vector_unuse(d, VMXNET3_MAX_INTRS);
+        vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS);
         msix_uninit(d, &s->msix_bar, &s->msix_bar);
     }
 }
-- 
1.9.3

  parent reply	other threads:[~2014-06-09 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 13:43 [Qemu-devel] [PULL 0/5] Net patches Stefan Hajnoczi
2014-06-09 13:43 ` [Qemu-devel] [PULL 1/5] net: xilinx_ethlite: Fix Rx-pong interrupt Stefan Hajnoczi
2014-06-09 13:43 ` Stefan Hajnoczi [this message]
2014-06-09 13:43 ` [Qemu-devel] [PULL 3/5] e1000: allow command-line selection of card model Stefan Hajnoczi
2014-06-09 13:43 ` [Qemu-devel] [PULL 4/5] tests: e1000: test additional device IDs Stefan Hajnoczi
2014-06-09 13:43 ` [Qemu-devel] [PULL 5/5] e1000: remove broken support for 82573L Stefan Hajnoczi
2014-06-09 14:26 ` [Qemu-devel] [PULL 0/5] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402321386-17773-3-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).